Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error when docker-env is used with non-docker runtime #7112

Merged
merged 1 commit into from
Mar 20, 2020

Conversation

tstromberg
Copy link
Contributor

Fixes #7111

Old UI

💣  Docker runtime check failed: sudo systemctl is-active docker failed: Process exited with status 3
output: "inactive"

😿  minikube is exiting due to an error. If the above message is not useful, open an issue:
👉  https://github.com/kubernetes/minikube/issues/new/choose

New UI

💣 The docker-env command is only compatible with the "docker" runtime, but this cluster was configured to use the "cri-o" runtime.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 19, 2020
@tstromberg tstromberg changed the title Improve error message when docker-env is used with an incompatible ru… Improve error when docker-env is used with non-docker runtime Mar 19, 2020
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 19, 2020
@tstromberg
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2020
@minikube-pr-bot
Copy link

Error: running mkcmp: exit status 1

@afbjorklund
Copy link
Collaborator

Looks like this got broken with the cruntime introduction ?

Old check:

func GetDockerActive(host *host.Host) (bool, error) {
       statusCmd := `sudo systemctl is-active docker`
       status, err := host.RunSSHCommand(statusCmd)
       // systemd returns error code on inactive
       s := strings.TrimSpace(status)
       return err == nil && s == "active", err
}

New check:

// Active returns if docker is active on the host
func (r *Docker) Active() bool {
       err := r.Runner.Run("systemctl is-active --quiet service docker")
       return err == nil
}

The systemd error codes are somewhat flawed.

@tstromberg tstromberg merged commit 729642e into kubernetes:master Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker-env with crio: Error getting service status: Process exited with status 3
5 participants