-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete: output underlying status failure, better machine function names #7043
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
Error: running mkcmp: exit status 1 |
Codecov Report
@@ Coverage Diff @@
## master #7043 +/- ##
==========================================
- Coverage 37.25% 36.89% -0.36%
==========================================
Files 145 146 +1
Lines 9114 9099 -15
==========================================
- Hits 3395 3357 -38
- Misses 5295 5330 +35
+ Partials 424 412 -12
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice clean up. Like to see more of these. Thank you
@medyagh : this PR broke the master, better to use "lgtm" than merge on these I think ? https://github.com/kubernetes/minikube/runs/506958518
|
Old UI if trying to delete a cluster while Docker is down:
It shows a warning, but no information as to why the status failed!
New UI if trying to delete a cluster while Docker is down:
This also removes some technical debt discovered while trying to improve this message: