-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Round suggested memory alloc by 100MB for VM's #6987
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
Error: running mkcmp: exit status 1 |
/ok-to-test |
Unit test:
|
All Times minikube: [ 64.239642 61.497723 66.504116] Average minikube: 64.080494 Averages Time Per Log
|
@tstromberg
|
…urn an error instead of exit early
I removed a line I didn't think was required, but was. Made it so that CalculateSizeInMB returns an exit rather than errors to make it debuggable. |
All Times Minikube (PR 6987): [ 66.226323 65.429023 66.518674] Average minikube: 65.143489 Averages Time Per Log
|
The TestFunctional/parallel/CertSync on Docker driver is a new flake: |
TestStartStop/group/crio is a failing test not related to this PR: |
@tstromberg looks good to me, feel free to merge whenever you are ready. |
Fixes #6964
There are now loads of tests, but here is a log from an example run:
I0310 16:00:45.581333 12309 start.go:870] Using suggested 6000MB memory alloc based on sys=32768MB, container=0MB