check if container is running after create #6924
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Codecov Report
@@ Coverage Diff @@
## master #6924 +/- ##
=======================================
Coverage 37.01% 37.01%
=======================================
Files 144 144
Lines 9010 9010
=======================================
Hits 3335 3335
Misses 5253 5253
Partials 422 422
|
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
| if err != nil { | ||
| return fmt.Errorf("temporary error checking status for %q : %v", p.Name, err) | ||
| } | ||
| if s != "running" { |
There was a problem hiding this comment.
nit: wdyt of having all possible states as constants? That way they can be reused later on.
There was a problem hiding this comment.
Thats a good idea ! eventually we should have a container status with libmachine's state strcut I will create an issue for this and do it in a following up PR
|
All Times minikube: [ 65.188597 62.721226 61.987752] Average minikube: 63.299192 Averages Time Per Log |
add up to 5 seconds of waiting to check and make sure the created container is "running"
and not "starting..."
fixes #6923