Switch --vm-driver paramter to --driver #6888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sharifelgamal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
k8s-ci-robot
added
size/XL
|
All Times minikube: [ 87.741876 89.119282 90.187295] Average Minikube (PR 6888): 89.687249 Averages Time Per Log |
|
All Times minikube: [ 90.880241 93.644633 88.886440] Average minikube: 91.137104 Averages Time Per Log |
Codecov Report
@@ Coverage Diff @@
## master #6888 +/- ##
==========================================
- Coverage 38.24% 38.23% -0.02%
==========================================
Files 142 142
Lines 8753 8770 +17
==========================================
+ Hits 3348 3353 +5
- Misses 4984 4996 +12
Partials 421 421
|
|
All Times minikube: [ 90.004690 90.031304 91.506289] Average minikube: 90.514094 Averages Time Per Log |
medyagh
approved these changes
Mar 4, 2020
medyagh
requested changes
Mar 4, 2020
|
/ok-to-test |
|
All Times minikube: [ 92.412958 90.028679 93.589648] Average minikube: 92.010428 Averages Time Per Log |
pkalever
pushed a commit
to pkalever/ceph-csi
that referenced
this pull request
Aug 20, 2020
$ minikube start --help
...
--vm-driver='': DEPRECATED, use `driver` instead.
...
'vm-driver' option is deprecated at minikube v1.8.0, we should really
start using 'driver'
Related: kubernetes/minikube#6888
Signed-off-by: Prasanna Kumar Kalever <[email protected]>
ceph-csi-bot
pushed a commit
to pkalever/ceph-csi
that referenced
this pull request
Aug 20, 2020
$ minikube start --help
...
--vm-driver='': DEPRECATED, use `driver` instead.
...
'vm-driver' option is deprecated at minikube v1.8.0, we should really
start using 'driver'
Related: kubernetes/minikube#6888
Signed-off-by: Prasanna Kumar Kalever <[email protected]>
mergify bot
pushed a commit
to ceph/ceph-csi
that referenced
this pull request
Aug 20, 2020
$ minikube start --help
...
--vm-driver='': DEPRECATED, use `driver` instead.
...
'vm-driver' option is deprecated at minikube v1.8.0, we should really
start using 'driver'
Related: kubernetes/minikube#6888
Signed-off-by: Prasanna Kumar Kalever <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6620
Anywhere where
--vm-driverwas accepted (minikube startandminikube configmost notably), now--driverwill be accepted.--vm-driveris still supported but deprecated and will be removed sometime in the future.