Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kic: fix service list for docker on osx #6830

Merged
merged 1 commit into from
Feb 28, 2020
Merged

kic: fix service list for docker on osx #6830

merged 1 commit into from
Feb 28, 2020

Conversation

josedonizetti
Copy link
Member

@josedonizetti josedonizetti commented Feb 28, 2020 •
edited
Loading

Fix for #6829

./out/minikube service list
|-------------|-----------------|--------------|-----|
|  NAMESPACE  |      NAME       | TARGET PORT  | URL |
|-------------|-----------------|--------------|-----|
| default     | hello-minikube1 |              |     |
| default     | kubernetes      | No node port |
| kube-system | kube-dns        | No node port |
|-------------|-----------------|--------------|-----|

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 28, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josedonizetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2020
medyagh
medyagh approved these changes Feb 28, 2020
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just could you please paste the output of service list in PR description?

@medyagh medyagh merged commit 15dfc5c into kubernetes:master Feb 28, 2020
@josedonizetti josedonizetti deleted the kic-fix-service-list branch February 28, 2020 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josedonizetti @k8s-ci-robot @medyagh