Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promote docker driver priority from "experimental" to "fallback" #6791

Merged
merged 1 commit into from
Mar 5, 2020

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented Feb 25, 2020

This PR should be merged. as last PR before releasing 1.8.0
If tests on this PR look good at that time, we can announce docker driver GA.

it will still not be the prefered as "hyperkit" on mac or "hyperv" on window but it will be higher priority

closes #6791

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 25, 2020
@medyagh medyagh changed the title mark docker driver from experimental to fallback wip: mark docker driver from experimental to fallback Feb 25, 2020
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 25, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2020
@medyagh
Copy link
Member Author

medyagh commented Mar 5, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 5, 2020
@medyagh medyagh changed the title wip: mark docker driver from experimental to fallback Increase docker driver priority from experimental to fallback Mar 5, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 5, 2020
@minikube-pr-bot
Copy link

All Times minikube: [ 90.126926 90.054317 92.855479]
All Times Minikube (PR 6791): [ 90.530727 91.367424 94.643487]

Average minikube: 91.012240
Average Minikube (PR 6791): 92.180546

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6791) |
+----------------------+-----------+--------------------+
| minikube v           |  0.316718 |           0.371059 |
| Creating kvm2        | 19.613462 |          20.022210 |
| Preparing Kubernetes | 49.599565 |          49.908691 |
| Pulling images       |           |                    |
| Launching Kubernetes | 20.203802 |          20.511263 |
| Waiting for cluster  |  0.061667 |           0.060694 |
+----------------------+-----------+--------------------+

@medyagh medyagh changed the title Increase docker driver priority from experimental to fallback promote docker driver priority from "experimental" to "fallback" Mar 5, 2020
@medyagh medyagh merged commit ba19967 into kubernetes:master Mar 5, 2020
@medyagh medyagh deleted the kic_ga branch May 2, 2020 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants