-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: do not change the profile to a none existing profile #6774
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @vikkyomkar! |
Hi @vikkyomkar. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #6774 +/- ##
==========================================
- Coverage 38.62% 38.62% -0.01%
==========================================
Files 142 142
Lines 8662 8663 +1
==========================================
Hits 3346 3346
- Misses 4897 4898 +1
Partials 419 419
|
/check-cla |
@vikkyomkar welcome to minikube contributors. Please make sure you have signed the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we are at it, Could you please change the emoji icon for this
"❌ if you want to create a profile you can by this command: minikube start -p lis"
Maybe choose a better than x
Maybe info or something that we don't see to X in a row in terminal
Thanks. @medyagh ... How about using something like below |
that looks perfect ! thank you |
@vikkyomkar please make sure the CLA is signed, so we could merge this PR . thank you :) |
I tried to sign CLA but getting some error. |
@vikkyomkar please make sure you have signed the CLA with the same email with your github here, https://identity.linuxfoundation.org/projects/cncf without that we can not merge this. |
@medyagh i followed the documentation to sign CLA using my github mail id...getting below message but didn't receive any validation mail..Also, I have raised a support ticket for this issue |
/check-cla |
1 similar comment
/check-cla |
@medyagh finally i could sign CLA. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RA489, vikkyomkar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good thank you for this contribution, This will improve minikube users experience :)
This PR fixes bug of switching to non existing Minikube profile
Fixes #6767
(base) vikky$ ./out/minikube profile
minikube
(base) vikky$ ./out/minikube profile lis
❌ profile "lis" not found
❌ if you want to create a profile you can by this command: minikube start -p lis
(base) vikkyq$ ./out/minikube profile
minikube
(base) vikky$ ./out/minikube docker-env
export DOCKER_TLS_VERIFY="1"
export DOCKER_HOST="tcp://192.168.99.100:2376"
export DOCKER_CERT_PATH="/Users/vikky/.minikube/certs"
export MINIKUBE_ACTIVE_DOCKERD="minikube"`
To point your shell to minikube's docker-daemon, run:
eval $(minikube -p minikube docker-env)