Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BumpUp]update registry 2.6.1 → 2.7.1 #6707

Merged
merged 2 commits into from
Feb 21, 2020
Merged

[BumpUp]update registry 2.6.1 → 2.7.1 #6707

merged 2 commits into from
Feb 21, 2020

Conversation

govargo
Copy link
Contributor

@govargo govargo commented Feb 20, 2020

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR bump up registry addon's image v2.16.1 to v2.17.1

Which issue(s) this PR fixes:

Fixes #6706

Does this PR introduce a user-facing change?

No.

Before

image: registry.hub.docker.com/library/registry:v2.16.1

After

image: registry.hub.docker.com/library/registry:v2.17.1

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 20, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @govargo. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 20, 2020
@govargo govargo changed the title update registry 2.6.1 → 2.7.1 [BumpUp]update registry 2.6.1 → 2.7.1 Feb 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: govargo
To complete the pull request process, please assign afbjorklund
You can assign the PR to them by writing /assign @afbjorklund in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@govargo
Copy link
Contributor Author

govargo commented Feb 20, 2020

/assign @afbjorklund

@govargo
Copy link
Contributor Author

govargo commented Feb 20, 2020

/retest

@k8s-ci-robot
Copy link
Contributor

@govargo: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@medyagh
Copy link
Member

medyagh commented Feb 20, 2020

the travis fail is related to this issue not your PR #6711

@medyagh
Copy link
Member

medyagh commented Feb 20, 2020

@govargo I noticed we dont have documentation on our website for addons registitry
we have one here for building images:
https://minikube.sigs.k8s.io/docs/tasks/building/

would you feel comfortable adding a page for addons registery and explaining how it is different than docker-env ? and an example of using it ?

@govargo
Copy link
Contributor Author

govargo commented Feb 21, 2020

Hi @medyagh.

I noticed there are an documentations about registry addon.
https://minikube.sigs.k8s.io/docs/tasks/docker_registry/
https://minikube.sigs.k8s.io/docs/tasks/registry/insecure/

So I think we don't have to add documentations about registry & usage.
But I noticed there is a 404 link in Using the Docker daemon docker registry section.

I'll add commit to fix this link error.

@medyagh medyagh merged commit 8507fe3 into kubernetes:master Feb 21, 2020
@govargo govargo deleted the update-registry branch March 6, 2020 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VersionUp: registry addon v2.16.1 → v2.17.1
5 participants