Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mount feature to kic drivers #6630

Merged
merged 8 commits into from
Feb 20, 2020
Merged

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented Feb 14, 2020

This PR enables mount on docker driver for mac
also adds a new line to the output to display the bind address

📁  Mounting host path /tmp/med1/ into VM as /med1 ...
    ▪ Mount type:   <no value>
    ▪ User ID:      docker
    ▪ Group ID:     docker
    ▪ Version:      9p2000.L
    ▪ Message Size: 262144
    ▪ Permissions:  755 (-rwxr-xr-x)
    ▪ Options:      map[]
    ▪ Bind Address: 127.0.0.1:56215
🚀  Userspace file server: ufs starting
✅  Successfully mounted /tmp/med1/ to /med1

📌  NOTE: This process must stay alive for the mount to be accessible 

closes #6628

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 14, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2020
@codecov-io
Copy link

Codecov Report

Merging #6630 into master will increase coverage by 1.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6630      +/-   ##
==========================================
+ Coverage   37.51%   38.52%   +1.01%     
==========================================
  Files         138      142       +4     
  Lines        8792     8603     -189     
==========================================
+ Hits         3298     3314      +16     
+ Misses       5080     4875     -205     
  Partials      414      414
Impacted Files Coverage Δ
pkg/minikube/cluster/cluster.go 13.33% <0%> (-36.67%) ⬇️
pkg/minikube/machine/machine.go 53.03% <0%> (-2.74%) ⬇️
cmd/minikube/cmd/logs.go 11.11% <0%> (ø) ⬆️
pkg/addons/addons.go 45.67% <0%> (ø) ⬆️
cmd/minikube/cmd/stop.go 0% <0%> (ø) ⬆️
cmd/minikube/cmd/docker-env.go 39.83% <0%> (ø) ⬆️
cmd/minikube/cmd/config/open.go 13.2% <0%> (ø) ⬆️
pkg/minikube/machine/cache_images.go 0% <0%> (ø) ⬆️
cmd/minikube/cmd/dashboard.go 1.69% <0%> (ø) ⬆️
cmd/minikube/cmd/kubectl.go 0% <0%> (ø) ⬆️
... and 30 more

@medyagh medyagh changed the title wip: add funcs to get routable host ip from inside container wip: add mount feature to kic drivers Feb 14, 2020
@medyagh medyagh changed the title wip: add mount feature to kic drivers add mount feature to kic drivers Feb 20, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 20, 2020
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 20, 2020
@tstromberg
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 20, 2020
@minikube-pr-bot
Copy link

All Times minikube: [ 95.479202 94.051319 93.095496]
All Times Minikube (PR 6630): [ 93.856823 92.255115 94.713617]

Average minikube: 94.208672
Average Minikube (PR 6630): 93.608518

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6630) |
+----------------------+-----------+--------------------+
| minikube v           |  0.127125 |           0.124857 |
| Creating kvm2        | 20.235421 |          20.439428 |
| Preparing Kubernetes | 51.736735 |          50.283013 |
| Pulling images       |           |                    |
| Launching Kubernetes | 20.413206 |          21.044815 |
| Waiting for cluster  |  0.058017 |           0.052925 |
+----------------------+-----------+--------------------+

@medyagh medyagh merged commit 7fddd05 into kubernetes:master Feb 20, 2020
@medyagh medyagh deleted the mount_kic branch May 2, 2020 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enable minikube mount for kic drivers (docker, podman)
5 participants