-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
preload_images: Fix unnecessary conversion (unconvert) #6607
Conversation
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@tstromberg I included that in the docker-env PR do u mind if we close this in favor of that ? |
Codecov Report
@@ Coverage Diff @@
## master #6607 +/- ##
=======================================
Coverage 37.56% 37.56%
=======================================
Files 138 138
Lines 8779 8779
=======================================
Hits 3298 3298
Misses 5065 5065
Partials 416 416 |
All Times minikube: [ 92.069450 91.629293 94.725684] Average minikube: 92.808142 Averages Time Per Log
|
@medyagh - It's easier to test the other PR's that are broken by this if this fix is it's own easily mergeable PR. |
agree ! you are right |
Fixes lint error: