Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preload_images: Fix unnecessary conversion (unconvert) #6607

Merged
merged 1 commit into from
Feb 13, 2020

Conversation

tstromberg
Copy link
Contributor

@tstromberg tstromberg commented Feb 12, 2020

Fixes lint error:

hack/preload-images/preload_images.go:92:72: unnecessary conversion (unconvert)
	args := []string{"scp", "-o", "StrictHostKeyChecking=no", "-i", string(sshKey), 

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 12, 2020
@tstromberg
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 12, 2020
@tstromberg tstromberg changed the title Fix unnecessary conversion (unconvert) preload_images: Fix unnecessary conversion (unconvert) Feb 12, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2020
@medyagh
Copy link
Member

medyagh commented Feb 12, 2020

@tstromberg I included that in the docker-env PR do u mind if we close this in favor of that ?

#6604

@codecov-io
Copy link

Codecov Report

Merging #6607 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6607   +/-   ##
=======================================
  Coverage   37.56%   37.56%           
=======================================
  Files         138      138           
  Lines        8779     8779           
=======================================
  Hits         3298     3298           
  Misses       5065     5065           
  Partials      416      416

@minikube-pr-bot
Copy link

All Times minikube: [ 92.069450 91.629293 94.725684]
All Times Minikube (PR 6607): [ 93.203225 93.458848 92.784941]

Average minikube: 92.808142
Average Minikube (PR 6607): 93.149005

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6607) |
+----------------------+-----------+--------------------+
| minikube v           |  0.213838 |           0.200640 |
| Creating kvm2        | 20.053581 |          20.239302 |
| Preparing Kubernetes | 49.529007 |          49.164674 |
| Pulling images       |           |                    |
| Launching Kubernetes | 20.641502 |          21.350475 |
| Waiting for cluster  |  0.396236 |           0.223368 |
+----------------------+-----------+--------------------+

@tstromberg
Copy link
Contributor Author

tstromberg commented Feb 13, 2020

@medyagh - It's easier to test the other PR's that are broken by this if this fix is it's own easily mergeable PR.

@medyagh
Copy link
Member

medyagh commented Feb 13, 2020

@medyagh - It's easier to test the other PR's that are broken by this if this fix is it's own easily mergeable PR.

agree ! you are right

@medyagh medyagh merged commit d07412f into kubernetes:master Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants