-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gvisor runsc version #6573
Conversation
Hi @wmuizelaar. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wmuizelaar The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cfc1d0d
to
8147db4
Compare
Can one of the admins verify this patch? |
/assign @sharifelgamal |
Codecov Report
@@ Coverage Diff @@
## master #6573 +/- ##
=======================================
Coverage 38.56% 38.56%
=======================================
Files 142 142
Lines 8642 8642
=======================================
Hits 3333 3333
Misses 4893 4893
Partials 416 416 |
/ok-to-test |
Error: running mkcmp: exit status 1 |
Gvisor test fails on kvm |
I'm having some trouble determining why it failed. Could you help me out with some pointers please @medyagh or @sharifelgamal ? |
/retest |
8a28d65
to
8691127
Compare
All Times Minikube (PR 6573): [ 93.080662 95.699197 95.434945] Average minikube: 93.392164 Averages Time Per Log
|
Not sure what I can do at the failing tests |
These failures don't look related to your PR at all, this change LGTM. |
No description provided.