Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gvisor runsc version #6573

Merged
merged 2 commits into from
Feb 19, 2020
Merged

Conversation

wmuizelaar
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 10, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @wmuizelaar. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wmuizelaar
To complete the pull request process, please assign sharifelgamal
You can assign the PR to them by writing /assign @sharifelgamal in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@wmuizelaar
Copy link
Contributor Author

/assign @sharifelgamal

@codecov-io
Copy link

codecov-io commented Feb 10, 2020

Codecov Report

Merging #6573 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6573   +/-   ##
=======================================
  Coverage   38.56%   38.56%           
=======================================
  Files         142      142           
  Lines        8642     8642           
=======================================
  Hits         3333     3333           
  Misses       4893     4893           
  Partials      416      416

@sharifelgamal
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 10, 2020
@minikube-pr-bot
Copy link

Error: running mkcmp: exit status 1

@medyagh
Copy link
Member

medyagh commented Feb 13, 2020

Gvisor test fails on kvm

@wmuizelaar
Copy link
Contributor Author

wmuizelaar commented Feb 16, 2020

Gvisor test fails on kvm

I'm having some trouble determining why it failed. Could you help me out with some pointers please @medyagh or @sharifelgamal ?

@wmuizelaar
Copy link
Contributor Author

/retest

@minikube-pr-bot
Copy link

All Times Minikube (PR 6573): [ 93.080662 95.699197 95.434945]
All Times minikube: [ 92.071391 93.237496 94.867604]

Average minikube: 93.392164
Average Minikube (PR 6573): 94.738268

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6573) |
+----------------------+-----------+--------------------+
| minikube v           |  0.227133 |           0.203359 |
| Creating kvm2        | 20.042824 |          20.845135 |
| Preparing Kubernetes | 50.160457 |          50.194158 |
| Pulling images       |           |                    |
| Launching Kubernetes | 20.882866 |          21.124148 |
| Waiting for cluster  |  0.389078 |           0.575853 |
+----------------------+-----------+--------------------+

@wmuizelaar
Copy link
Contributor Author

Not sure what I can do at the failing tests

@sharifelgamal
Copy link
Collaborator

These failures don't look related to your PR at all, this change LGTM.

@sharifelgamal sharifelgamal merged commit 14af1fc into kubernetes:master Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants