Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add packaging of the falco_probe kernel module #6560

Merged
merged 3 commits into from
Feb 22, 2020

Conversation

afbjorklund
Copy link
Collaborator

@afbjorklund afbjorklund commented Feb 8, 2020

See also https://falco.org/docs/installation/ on how to install the rest of it (i.e. falco)

Minikube doesn't feature a compiler or kernel headers, so provide a pre-built module.

$ minikube kubectl -- logs -l app=falco-example
Your kernel headers for kernel 4.19.88 cannot be found at
/lib/modules/4.19.88/build or /lib/modules/4.19.88/source.
* Running dkms build failed, couldn't find /var/lib/dkms/falco/0.19.0/build/make.log
* Trying to load a system falco-probe, if present
falco-probe found and loaded with modprobe

Installs /lib/modules/${KERNEL_VERSION}/extra/falco-probe.ko on the ISO


Sysdig used to provide prebuilt modules for minikube, but have stopped doing so after 0.18...

To address this, starting with falco 0.13.1 we pre-build kernel modules for the last 10 Minikube versions and make them available at https://s3.amazonaws.com/download.draios.com. This allows the download fallback step to succeed with a loadable kernel module.

Going forward, we’ll continue to support 10 most recent versions of Minikube with each new Falco release. We currently retain previously-built kernel modules for download, so we will continue to provide limited historical support as well.

https://s3.amazonaws.com/download.draios.com/stable/sysdig-probe-binaries/index.html

Eventually it might become available from https://github.com/falcosecurity/kernel-module

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 8, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2020
@afbjorklund
Copy link
Collaborator Author

Related issue in the upstream project: falcosecurity/falco#1009

@codecov-io
Copy link

codecov-io commented Feb 9, 2020

Codecov Report

Merging #6560 into master will increase coverage by 0.46%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6560      +/-   ##
==========================================
+ Coverage    38.1%   38.56%   +0.46%     
==========================================
  Files         137      142       +5     
  Lines        8690     8642      -48     
==========================================
+ Hits         3311     3333      +22     
+ Misses       4963     4893      -70     
  Partials      416      416
Impacted Files Coverage Δ
pkg/minikube/cluster/cluster.go 13.33% <0%> (-36.67%) ⬇️
pkg/minikube/driver/driver.go 57.5% <0%> (-3.03%) ⬇️
pkg/minikube/machine/machine.go 53.03% <0%> (-2.74%) ⬇️
cmd/minikube/cmd/logs.go 11.11% <0%> (ø) ⬆️
pkg/addons/addons.go 45.67% <0%> (ø) ⬆️
cmd/minikube/cmd/stop.go 0% <0%> (ø) ⬆️
cmd/minikube/cmd/config/open.go 13.2% <0%> (ø) ⬆️
pkg/minikube/machine/cache_images.go 0% <0%> (ø) ⬆️
pkg/minikube/machine/client.go 43.84% <0%> (ø) ⬆️
pkg/addons/kubectl.go 56.52% <0%> (ø) ⬆️
... and 38 more

@afbjorklund afbjorklund self-assigned this Feb 15, 2020
@afbjorklund afbjorklund added this to the v1.8.0 Feb 28 milestone Feb 15, 2020
@medyagh medyagh merged commit b49d446 into kubernetes:master Feb 22, 2020
@afbjorklund
Copy link
Collaborator Author

@medyagh : Thanks for merging, we should bump it to 0.20 before minikube v1.8.0:

falcosecurity/falco#1048

https://github.com/falcosecurity/falco/milestone/5

But hopefully that should just be a minor version increase, and nothing more than that.

@afbjorklund
Copy link
Collaborator Author

It was bumped in fc3a565 (#6777)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants