Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ca-certificates directory for distros that do not include it #6545

Merged
merged 4 commits into from
Feb 7, 2020

Conversation

tstromberg
Copy link
Contributor

Fixes #6542

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2020
pkg/minikube/cluster/start.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 7, 2020
@codecov-io
Copy link

Codecov Report

Merging #6545 into master will decrease coverage by 0.02%.
The diff coverage is 84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6545      +/-   ##
==========================================
- Coverage   37.91%   37.88%   -0.03%     
==========================================
  Files         137      137              
  Lines        8683     8676       -7     
==========================================
- Hits         3292     3287       -5     
+ Misses       4978     4976       -2     
  Partials      413      413
Impacted Files Coverage Δ
pkg/minikube/bootstrapper/bsutil/versions.go 81.81% <ø> (ø) ⬆️
pkg/minikube/cluster/start.go 52.33% <ø> (ø) ⬆️
pkg/minikube/bootstrapper/bsutil/kubeadm.go 82.08% <100%> (ø) ⬆️
cmd/minikube/cmd/start.go 22.17% <16.66%> (+0.07%) ⬆️
pkg/minikube/bootstrapper/certs.go 75.24% <87.5%> (ø) ⬆️
cmd/minikube/cmd/env.go 57.37% <94.28%> (-0.44%) ⬇️

@medyagh
Copy link
Member

medyagh commented Feb 7, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 7, 2020
@minikube-pr-bot
Copy link

All Times Minikube (PR 6545): [ 95.955883 92.372326 91.608516]
All Times minikube: [ 91.065509 93.047647 94.101828]

Average Minikube (PR 6545): 93.312242
Average minikube: 92.738328

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6545) |
+----------------------+-----------+--------------------+
| minikube v           |  0.206669 |           0.204820 |
| Creating kvm2        | 19.782795 |          20.205173 |
| Preparing Kubernetes | 50.196398 |          49.882246 |
| Pulling images       |           |                    |
| Launching Kubernetes | 20.706054 |          21.406061 |
| Waiting for cluster  |  0.236699 |           0.064100 |
+----------------------+-----------+--------------------+

@tstromberg tstromberg merged commit b0608d6 into kubernetes:master Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

none: Failed to setup certs: open /usr/share/ca-certificates/minikubeCA.pem: no such file or directory
5 participants