Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gvisor fixes for v1.7.0 #6512

Merged
merged 3 commits into from
Feb 5, 2020
Merged

Conversation

tstromberg
Copy link
Contributor

@tstromberg tstromberg commented Feb 5, 2020

  • /tmp/gvisor must exist before we can copy files into it
  • Don't attempt to kubectl apply non-YAML files in an addon

Fixes error:

⚠️ Enabling 'gvisor' returned an error: running callbacks: [sudo test -d /tmp/gvisor && sudo scp -t /tmp/gvisor && sudo touch -d "0001-01-01 00:00:00 +0000" /tmp/gvisor/gvisor-config.toml: Process exited with status 1

and:

⚠️ Enabling 'gvisor' returned an error: running callbacks: [addon apply: sudo KUBECONFIG=/var/lib/minikube/kubeconfig /var/lib/minikube/binaries/v1.17.2/kubectl apply -f /etc/kubernetes/addons/gvisor-pod.yaml -f /etc/kubernetes/addons/gvisor-runtimeclass.yaml -f /tmp/gvisor/gvisor-config.toml: Process exited with status 1

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 5, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2020
@medyagh
Copy link
Member

medyagh commented Feb 5, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 5, 2020
@minikube-pr-bot
Copy link

Error: running mkcmp: exit status 1

@codecov-io
Copy link

Codecov Report

Merging #6512 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6512      +/-   ##
==========================================
- Coverage   37.95%   37.95%   -0.01%     
==========================================
  Files         138      138              
  Lines        8707     8708       +1     
==========================================
  Hits         3305     3305              
- Misses       4985     4986       +1     
  Partials      417      417
Impacted Files Coverage Δ
pkg/minikube/cluster/start.go 52.33% <ø> (ø) ⬆️
pkg/addons/addons.go 45.67% <0%> (-0.29%) ⬇️

@tstromberg tstromberg merged commit 950fc79 into kubernetes:master Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants