Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trim kic base image and disable containerd by default #6478

Merged
merged 1 commit into from
Feb 3, 2020

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented Feb 3, 2020

This PR:

  • Trim the kicimage by 800 mb
gcr.io/k8s-minikube/kicbase   <none>               93d2b8cf202a        4 days ago          1.76GB
gcr.io/k8s-minikube/kicbase   v0.0.4               87a690612c07        6 minutes ago       802MB

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 3, 2020
@medyagh medyagh changed the title trim kic base image trim kic base image and disable containerd by default Feb 3, 2020
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 3, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2020
@medyagh
Copy link
Member Author

medyagh commented Feb 3, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 3, 2020
@minikube-pr-bot
Copy link

All Times minikube: [ 95.163639 99.436029 99.213259]
All Times Minikube (PR 6478): [ 98.497773 98.429117 96.817823]

Average minikube: 97.937642
Average Minikube (PR 6478): 97.914904

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6478) |
+----------------------+-----------+--------------------+
| minikube v           |  0.318136 |           0.306889 |
| Creating kvm2        | 20.043503 |          20.207369 |
| Preparing Kubernetes | 49.954555 |          49.899117 |
| Pulling images       |  3.914106 |           3.702663 |
| Launching Kubernetes | 20.300726 |          20.309465 |
| Waiting for cluster  |  1.054628 |           1.058741 |
+----------------------+-----------+--------------------+

@medyagh medyagh merged commit 3dd5495 into kubernetes:master Feb 3, 2020
@medyagh medyagh deleted the trim_kic_image branch February 3, 2020 23:31
@medyagh medyagh mentioned this pull request Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kic: disable containerd service by default Trim kic base image
4 participants