Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tunnel for docker driver on darwin #6460

Merged
merged 14 commits into from
Feb 24, 2020
Merged

add tunnel for docker driver on darwin #6460

merged 14 commits into from
Feb 24, 2020

Conversation

josedonizetti
Copy link
Member

@josedonizetti josedonizetti commented Feb 1, 2020 •
edited
Loading

Fix for #6302

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josedonizetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2020
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 5, 2020
@medyagh
Copy link
Member

medyagh commented Feb 23, 2020

@josedonizetti this PR needs an update for build failure (some config fields changed)

medyagh
medyagh approved these changes Feb 24, 2020
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will make a follow up PR to fix the issue

@medyagh medyagh merged commit 5fe81c8 into kubernetes:master Feb 24, 2020
@medyagh medyagh changed the title WIP: kic darwin tunnel kic darwin tunnel Feb 24, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 24, 2020
@medyagh medyagh changed the title kic darwin tunnel add Tunnel for docker driver on darwin Feb 24, 2020
@medyagh medyagh changed the title add Tunnel for docker driver on darwin add tunnel for docker driver on darwin Feb 24, 2020
@josedonizetti josedonizetti deleted the kic-darwin-tunnel branch February 24, 2020 22:44
@medyagh medyagh mentioned this pull request Feb 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

@tstromberg tstromberg Awaiting requested review from tstromberg

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josedonizetti @k8s-ci-robot @medyagh