Add addon enablement to start

[tstromberg]

This PR explicitly enables addons on startup, in lieu of there being an addon-manager to do so.

There is a new line emitted during startup:

🚀  Launching Kubernetes ... 
🌟  Enabling addons: storage-provisioner, default-storageclass
⌛  Waiting for cluster to come online ...

Behavior changes

There is also a behavioral change: if an addon is enabled/disabled, and you attempt to enable it again, it will run the underlying kubectl command. It should still be idempotent.

I expect this will add ~1 second to our start time, but it does restore the previous behavior.

API changes

The addons package has a new function to handle startup logic: addons.Start(). This obsoletes what was in start.go:enableAddons() and files.go:AddAddons()

To improve testing, the following public functions now take a profile name:

• addon.IsEnabled()
• cluster.IsHostRunning()

Fixes #6363

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tstromberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[priyawadhwa]

LGTM, looks like there's a unit test failure:

--- FAIL: TestEnableAndDisableAddon (0.00s)
    --- FAIL: TestEnableAndDisableAddon/test_enable (0.00s)
        addons_test.go:100: Disable returned unexpected error: running callbacks: [get the addon status: stat /home/travis/.minikube/profiles/config.json: no such file or directory]
    --- FAIL: TestEnableAndDisableAddon/test_disable (0.00s)
        addons_test.go:100: Disable returned unexpected error: running callbacks: [get the addon status: stat /home/travis/.minikube/profiles/config.json: no such file or directory]

[medyagh]

looks good after unit tests fix

[priyawadhwa]

travis caught another unit test:

--- FAIL: TestIsAddonAlreadySet (0.00s)
    addons_test.go:51: Did not get expected status, 
        
         expected ingress already disabled

and a lint error:

cmd/minikube/cmd/start.go:48: File is not `goimports`-ed (goimports)
	cmdcfg "k8s.io/minikube/cmd/minikube/cmd/config"

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@b971242). Click here to learn what that means.
The diff coverage is 22.95%.

@@            Coverage Diff            @@
##             master    #6440   +/-   ##
=========================================
  Coverage          ?   37.98%           
=========================================
  Files             ?      128           
  Lines             ?     8708           
  Branches          ?        0           
=========================================
  Hits              ?     3308           
  Misses            ?     4974           
  Partials          ?      426

Impacted Files	Coverage Δ
cmd/minikube/cmd/config/profile_list.go	3.94% <0%> (ø)
cmd/minikube/cmd/config/addons_list.go	11.59% <0%> (ø)
cmd/minikube/cmd/config/open.go	13.2% <0%> (ø)
pkg/minikube/cluster/cluster.go	37.56% <0%> (ø)
pkg/addons/kubectl.go	56.52% <0%> (ø)
cmd/minikube/cmd/config/profile.go	0% <0%> (ø)
cmd/minikube/cmd/dashboard.go	1.69% <0%> (ø)
cmd/minikube/cmd/pause.go	8.1% <0%> (ø)
cmd/minikube/cmd/kubectl.go	0% <0%> (ø)
cmd/minikube/cmd/unpause.go	7.89% <0%> (ø)
... and 6 more

[priyawadhwa]

LGTM! Just a couple nits, but they can be addressed in a separate PR if you prefer.

[priyawadhwa]

/ok-to-test

[minikube-pr-bot]

Error: running mkcmp: exit status 1

[minikube-pr-bot]

Error: running mkcmp: exit status 1

[priyawadhwa]

nice!

[minikube-pr-bot]

All Times minikube: [ 96.361238 97.875949 96.325792]
All Times Minikube (PR 6440): [ 97.035521 102.032158 94.476924]

Average minikube: 96.854326
Average Minikube (PR 6440): 97.848201

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6440) |
+----------------------+-----------+--------------------+
| minikube v           |  0.287564 |           0.282742 |
| Creating kvm2        | 20.096272 |          20.326566 |
| Preparing Kubernetes | 49.828888 |          50.622562 |
| Pulling images       |  3.908831 |           3.484384 |
| Launching Kubernetes | 19.801032 |          20.187780 |
| Waiting for cluster  |  2.879825 |           1.058750 |
+----------------------+-----------+--------------------+