Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary crio restart to improve start latency #6369

Merged
merged 1 commit into from
Jan 22, 2020

Conversation

priyawadhwa
Copy link

Reorganize buildroot.go by container runtime and remove unnecessary "sudo systemctl restart crio" to save time on 'minikube start'

Also, only set up the container runtime being used instead of all of them.

…sudo systemctl restart crio" to save time on 'minikube start'
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 22, 2020
@priyawadhwa
Copy link
Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 22, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: priyawadhwa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2020
@codecov-io
Copy link

Codecov Report

Merging #6369 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6369   +/-   ##
=======================================
  Coverage   38.33%   38.33%           
=======================================
  Files         124      124           
  Lines        8365     8365           
=======================================
  Hits         3207     3207           
  Misses       4738     4738           
  Partials      420      420

@priyawadhwa priyawadhwa changed the title Remove unnecessary crio restart to improve start latencyt Remove unnecessary crio restart to improve start latency Jan 22, 2020
@kubernetes kubernetes deleted a comment from minikube-pr-bot Jan 22, 2020
@tstromberg
Copy link
Contributor

/ok-to-test

@tstromberg tstromberg merged commit 1af9d83 into kubernetes:master Jan 22, 2020
@priyawadhwa priyawadhwa deleted the refactor-crio branch January 22, 2020 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants