Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add varlink program for using with podman-remote #6349

Merged
merged 1 commit into from
Jan 24, 2020

Conversation

afbjorklund
Copy link
Collaborator

@afbjorklund afbjorklund commented Jan 19, 2020

Using podman-remote requires "varlink bridge"

For #6350

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2020
@codecov-io
Copy link

codecov-io commented Jan 19, 2020

Codecov Report

Merging #6349 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6349   +/-   ##
=======================================
  Coverage   38.35%   38.35%           
=======================================
  Files         124      124           
  Lines        8370     8370           
=======================================
  Hits         3210     3210           
  Misses       4738     4738           
  Partials      422      422

Using podman-remote requires "varlink bridge"
@medyagh
Copy link
Member

medyagh commented Jan 21, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 21, 2020
@minikube-pr-bot
Copy link

All Times minikube: [ 224.314361 243.748209 225.814085]
All Times Minikube (PR 6349): [ 243.632852 225.375465 242.068656]

Average minikube: 231.292218
Average Minikube (PR 6349): 237.025658

Averages Time Per Log

+----------------------+------------+--------------------+
|         LOG          |  MINIKUBE  | MINIKUBE (PR 6349) |
+----------------------+------------+--------------------+
| minikube v           |   0.290460 |           0.287189 |
| Creating kvm2        | 160.910743 |         160.905100 |
| Preparing Kubernetes |  41.294495 |          40.905043 |
| Pulling images       |   2.525171 |           2.413958 |
| Launching Kubernetes |  24.169371 |          30.076565 |
| Waiting for cluster  |   2.050683 |           2.388255 |
+----------------------+------------+--------------------+

@tstromberg tstromberg merged commit 76bed59 into kubernetes:master Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants