Remove addon manager

[priyawadhwa]

Fixes #6333

[priyawadhwa]

/ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: priyawadhwa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [priyawadhwa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov-io]

Codecov Report

Merging #6334 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6334      +/-   ##
==========================================
- Coverage   38.35%   38.32%   -0.03%     
==========================================
  Files         124      124              
  Lines        8370     8367       -3     
==========================================
- Hits         3210     3207       -3     
  Misses       4738     4738              
  Partials      422      422

Impacted Files	Coverage Δ
pkg/minikube/assets/addons.go	37.93% <ø> (ø)	⬆️
pkg/minikube/logs/logs.go	2.35% <ø> (ø)	⬆️
pkg/minikube/bootstrapper/images/images.go	100% <ø> (ø)	⬆️

[minikube-bot]

Error: running mkcmp
2020/01/16 20:28:07 Executing run 1/3...
2020/01/16 20:28:07 Running: [/home/performance-monitor/minikube/out/minikube start]...
2020/01/16 20:28:07 0.338682: * minikube v1.7.0-beta.0 on Debian 9.11
2020/01/16 20:28:07 0.045711: * Selecting 'kvm2' driver from user configuration (alternates: [none docker])
! Unable to update kvm2 driver: download failed: https://github.com/kubernetes/minikube/releases/download/v1.7.0-beta.0/docker-machine-driver-kvm2?checksum=file:https://github.com/kubernetes/minikube/releases/download/v1.7.0-beta.0/docker-machine-driver-kvm2.sha256: invalid checksum: Error downloading checksum file: bad response code: 404
2020/01/16 20:28:08 0.474301: * Downloading driver docker-machine-driver-kvm2:
*
X Unable to start VM. Please investigate and run 'minikube delete' if possible

• Error: [KVM2_NOT_FOUND] new host: Driver "kvm2" not found. Do you have the plugin binary "docker-machine-driver-kvm2" accessible in your PATH?
• Suggestion: Please install the minikube kvm2 VM driver, or select an alternative --vm-driver
• Documentation: https://minikube.sigs.k8s.io/docs/reference/drivers/kvm2/
  : exit status 1

[medyagh]

in the .txt log files I see

}
HTTP code 403! Retrying in 128 ..
{
  "message": "API rate limit exceeded for user ID 20374350.",
  "documentation_url": "https://developer.github.com/v3/#rate-limiting"
}
HTTP code 403! Retrying in 256 ..
Build step 'Execute shell' marked build as failure

which are realted github api rate limit
#6308

[tstromberg]

/ok-to-test

I'm concerned about the Hyper-V errors, but they may be just general timeouts. I want to see the data on the other drivers.

[minikube-pr-bot]

All Times Minikube (PR 6334): [ 242.467969 239.483258 242.277284]
All Times minikube: [ 244.566446 245.408520 223.891013]

Average minikube: 237.955326
Average Minikube (PR 6334): 241.409504

Averages Time Per Log

+----------------------+------------+--------------------+
|         LOG          |  MINIKUBE  | MINIKUBE (PR 6334) |
+----------------------+------------+--------------------+
| minikube v           |   0.289382 |           0.302718 |
| Creating kvm2        | 160.942602 |         159.724545 |
| Preparing Kubernetes |  41.070302 |          39.520806 |
| Pulling images       |   2.298497 |           2.224748 |
| Launching Kubernetes |  30.590205 |          36.683943 |
| Waiting for cluster  |   2.713580 |           2.902757 |
+----------------------+------------+--------------------+

[priyawadhwa]

In case we need this in future, here are the integration test logs for the other drivers:

VirtualBox MaxOS

none

hyperkit macos

virtualbox linux