-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure etcd and kube-proxy metrics to listen on minikube node IP #6322
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chancez The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
52f95a8
to
44c7c48
Compare
/assign @priyawadhwa |
Codecov Report
@@ Coverage Diff @@
## master #6322 +/- ##
=======================================
Coverage 38.23% 38.23%
=======================================
Files 123 123
Lines 8269 8269
=======================================
Hits 3162 3162
Misses 4696 4696
Partials 411 411 |
/ok-to-test |
Error: running mkcmp
|
the ingress integraiton tests seems to be broken across all ... could it be realted? |
I see registry failing in hyperkit and ingress failing in kvm in the CI. It's possible this change is creating an invalid config or something. I'll run integration tests locally and see what I can find. |
Error: running mkcmp: exit status 1 |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried
curl http://$(minikube ip):2381/metrics
and it worked. LGTM.
Configures etcd and kube-proxy to expose their metrics on the minikube node IP
instead of localhost so that their metrics can be scraped by Prometheus.
Metrics are already exposed for other control plane services such as kube
apiserver, controller-manager, and scheduler, this simply updates etcd and
kube-proxy to match.
This is desirable so that Prometheus monitoring works within minikube.