Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use an arch suffix for the coredns name #6243

Merged
merged 1 commit into from
Jan 30, 2020

Conversation

afbjorklund
Copy link
Collaborator

They are using multi-arch images instead...
So don't append something like -arm64 to it.

Just use e.g. "k8s.gcr.io/coredns:1.6.5",
and Docker will pull the right platform image.

See https://hub.docker.com/r/coredns/coredns

As seen in #6007 et al

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 8, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 8, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2020
@codecov-io
Copy link

Codecov Report

Merging #6243 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #6243   +/-   ##
======================================
  Coverage    38.5%   38.5%           
======================================
  Files         122     122           
  Lines        8145    8145           
======================================
  Hits         3136    3136           
  Misses       4600    4600           
  Partials      409     409
Impacted Files Coverage Δ
pkg/minikube/bootstrapper/images/kubeadm.go 96% <100%> (ø) ⬆️

@tstromberg
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 8, 2020
@minikube-bot
Copy link
Collaborator

All Times minikube: [ 122.129643 126.740795 123.893050]
All Times Minikube (PR 6243): [ 125.035215 125.711807 126.940731]

Average minikube: 124.254496
Average Minikube (PR 6243): 125.895918

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6243) |
+----------------------+-----------+--------------------+
| minikube v           |  0.689353 |           0.542738 |
| Creating kvm2        | 47.559917 |          46.995472 |
| Preparing Kubernetes | 49.613814 |          51.764089 |
| Pulling images       |  3.031266 |           2.599605 |
| Launching Kubernetes | 20.546731 |          21.190348 |
| Waiting for cluster  |  2.763252 |           2.755256 |
| Done                 |           |                    |
|                      |  0.051075 |           0.045697 |
+----------------------+-----------+--------------------+

@medyagh
Copy link
Member

medyagh commented Jan 13, 2020

@afbjorklund looks good to me also, after resolving the conflict

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2020
They are using multi-arch images instead...
So don't append something like -arm64 to it.

Just use e.g. "k8s.gcr.io/coredns:1.6.5",
and Docker will pull the right platform image.
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2020
@minikube-pr-bot
Copy link

Error: running mkcmp: exit status 1

@tstromberg tstromberg merged commit eeb867f into kubernetes:master Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants