-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not use an arch suffix for the coredns name #6243
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #6243 +/- ##
======================================
Coverage 38.5% 38.5%
======================================
Files 122 122
Lines 8145 8145
======================================
Hits 3136 3136
Misses 4600 4600
Partials 409 409
|
/ok-to-test |
All Times minikube: [ 122.129643 126.740795 123.893050] Average minikube: 124.254496 Averages Time Per Log
|
@afbjorklund looks good to me also, after resolving the conflict |
They are using multi-arch images instead... So don't append something like -arm64 to it. Just use e.g. "k8s.gcr.io/coredns:1.6.5", and Docker will pull the right platform image.
0878075
to
9e317ac
Compare
Error: running mkcmp: exit status 1 |
They are using multi-arch images instead...
So don't append something like -arm64 to it.
Just use e.g. "k8s.gcr.io/coredns:1.6.5",
and Docker will pull the right platform image.
See https://hub.docker.com/r/coredns/coredns
As seen in #6007 et al