Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for nil ref and img before passing them into go-containerregistry #6236

Merged
merged 2 commits into from
Jan 22, 2020
Merged

Check for nil ref and img before passing them into go-containerregistry #6236

merged 2 commits into from
Jan 22, 2020

Conversation

tstromberg
Copy link
Contributor

May fix #6147

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 8, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2020
@codecov-io
Copy link

codecov-io commented Jan 8, 2020 •
edited
Loading

Codecov Report

Merging #6236 into master will decrease coverage by 0.23%.
The diff coverage is 54.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6236      +/-   ##
==========================================
- Coverage    38.5%   38.26%   -0.24%     
==========================================
  Files         122      124       +2     
  Lines        8145     8261     +116     
==========================================
+ Hits         3136     3161      +25     
- Misses       4600     4690      +90     
- Partials      409      410       +1
Impacted Files Coverage Δ
pkg/minikube/bootstrapper/bsutil/binaries.go 13.33% <ø> (ø) ⬆️
pkg/minikube/bootstrapper/bsutil/featuregates.go 84% <ø> (ø) ⬆️
pkg/minikube/bootstrapper/bsutil/extraconfig.go 79.1% <ø> (ø) ⬆️
pkg/util/constants.go 87.5% <ø> (ø) ⬆️
pkg/minikube/bootstrapper/bootstrapper.go 0% <0%> (ø) ⬆️
pkg/minikube/bootstrapper/images/kic.go 0% <0%> (ø)
pkg/minikube/bootstrapper/bsutil/rbac.go 0% <0%> (ø)
pkg/minikube/driver/install.go 7.69% <0%> (-0.65%) ⬇️
pkg/minikube/bootstrapper/bsutil/kubelet.go 53.84% <0%> (ø) ⬆️
pkg/minikube/bootstrapper/bsutil/files.go 0% <0%> (ø) ⬆️
... and 17 more

@medyagh
Copy link
Member

medyagh commented Jan 8, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 8, 2020
@minikube-bot
Copy link
Collaborator

All Times minikube: [ 123.504306 124.749722 123.867602]
All Times Minikube (PR 6236): [ 126.651196 112.052563 127.269272]

Average minikube: 124.040543
Average Minikube (PR 6236): 121.991010

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6236) |
+----------------------+-----------+--------------------+
| minikube v           |  0.449330 |           0.451756 |
| Creating kvm2        | 46.960561 |          47.066479 |
| Preparing Kubernetes | 50.060594 |          48.190809 |
| Pulling images       |  2.685875 |           2.772381 |
| Launching Kubernetes | 21.000409 |          20.535635 |
| Waiting for cluster  |  2.836293 |           2.927241 |
| Done                 |           |                    |
|                      |  0.047482 |           0.046710 |
+----------------------+-----------+--------------------+

@minikube-bot
Copy link
Collaborator

All Times Minikube (PR 6236): [ 113.510606 122.009113 122.786632]
All Times minikube: [ 125.255737 110.874980 122.419140]

Average minikube: 119.516619
Average Minikube (PR 6236): 119.435450

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6236) |
+----------------------+-----------+--------------------+
| minikube v           |  0.314207 |           0.288336 |
| Creating kvm2        | 46.502087 |          46.038846 |
| Preparing Kubernetes | 47.264376 |          48.721583 |
| Pulling images       |  2.641513 |           2.611245 |
| Launching Kubernetes | 19.985052 |          18.999561 |
| Waiting for cluster  |  2.757684 |           2.727385 |
| Done                 |           |                    |
|                      |  0.053443 |           0.048495 |
+----------------------+-----------+--------------------+

@medyagh
Copy link
Member

medyagh commented Jan 13, 2020

/retest this please

@minikube-pr-bot
Copy link

Error: running mkcmp: exit status 1

medyagh
medyagh approved these changes Jan 22, 2020
View reviewed changes
pkg/minikube/image/cache.go Outdated
@@ -72,10 +72,10 @@ func SaveToDir(images []string, cacheDir string) error {
}

// saveToTarFile caches an image
func saveToTarFile(image, dst string) error {
func saveToTarFile(iname, dst string) error {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be iName ? or imgName

@medyagh
Copy link
Member

medyagh commented Jan 22, 2020

/retest this please

@medyagh medyagh merged commit abfcf79 into kubernetes:master Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@blueelvis blueelvis Awaiting requested review from blueelvis

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tarball.Write panic: runtime error: invalid memory address or nil pointer dereference
6 participants
@tstromberg @k8s-ci-robot @codecov-io @medyagh @minikube-bot @minikube-pr-bot