-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed IPv6 format for SSH #6110
Conversation
Welcome @digitalcoyote! |
Hi @digitalcoyote. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: digitalcoyote The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #6110 +/- ##
======================================
Coverage 36.7% 36.7%
======================================
Files 113 113
Lines 8355 8355
======================================
Hits 3067 3067
Misses 4887 4887
Partials 401 401
|
Finally got to test it. I don't know if I'll hit another issue, but It's gotten further than before. I double checked the project for another instance of this and did not see one (but as I said I am unfamiliar with Go so I may have overlooked one). |
/ok-to-test |
Not very familiar with go, so I have yet to be able to test this, but it appears to be similar to the issue in #576 . I made a similar fix to #625 and I'm working on setting up golang so I can test it.