Make it possible to recover from a previously aborted StartCluster (Ctrl-C)

[tstromberg]

I ran into an issue earlier today where minikube was failing:

W1114 14:23:00.947646   38011 exit.go:101] Error restarting cluster: apiserver healthz: apiserver healthz never reported healthy

💣  Error restarting cluster: apiserver healthz: apiserver healthz never reported healthy

This was because the kubelet was crash-looping due to a missing file, probably because I hit Ctrl-C on a previous run:

Nov 14 22:19:36 minikube kubelet[2939]: F1114 22:19:36.393394    2939 server.go:196] failed to load Kubelet config file /var/lib/kubelet/config.yaml, error failed to read kubelet config file "/var/lib/kubelet/config.yaml", error: open /var/lib/kubelet/config.yaml: no such file or directory

[tstromberg]

/ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tstromberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[minikube-bot]

Error: running mkcmp: exit status 1

[codecov-io]

Codecov Report

Merging #5916 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #5916      +/-   ##
==========================================
- Coverage    36.1%   36.09%   -0.01%     
==========================================
  Files         110      110              
  Lines        8206     8208       +2     
==========================================
  Hits         2963     2963              
- Misses       4852     4854       +2     
  Partials      391      391

Impacted Files	Coverage Δ
pkg/minikube/bootstrapper/bootstrapper.go	0% <ø> (ø)	⬆️
cmd/minikube/cmd/start.go	19.53% <ø> (+0.16%)	⬆️
pkg/minikube/bootstrapper/kubeadm/kubeadm.go	18.49% <0%> (-0.35%)	⬇️

[minikube-bot]

All Times minikube: [ 106.526694 124.112715 120.451782]
All Times Minikube (PR 5916): [ 123.426669 120.938330 123.629328]

Average minikube: 117.030397
Average Minikube (PR 5916): 122.664776

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 5916) |
+----------------------+-----------+--------------------+
| minikube v           |  0.296829 |           0.297764 |
| Creating kvm2        | 38.314676 |          38.341729 |
| Preparing Kubernetes | 49.254220 |          54.136212 |
| Pulling images       |  2.656026 |           2.811052 |
| Launching Kubernetes | 18.926246 |          19.477069 |
| Waiting for cluster  |  7.539914 |           7.559275 |
+----------------------+-----------+--------------------+

[minikube-bot]

All Times minikube: [ 130.136296 133.110904 126.252479]
All Times Minikube (PR 5916): [ 121.506751 128.998139 131.881712]

Average minikube: 129.833226
Average Minikube (PR 5916): 127.462200

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 5916) |
+----------------------+-----------+--------------------+
| minikube v           |  0.350372 |           0.348966 |
| Creating kvm2        | 42.168255 |          40.582970 |
| Preparing Kubernetes | 55.649321 |          55.572103 |
| Pulling images       |  2.974075 |           3.075344 |
| Launching Kubernetes | 20.565496 |          20.079992 |
| Waiting for cluster  |  8.075019 |           7.751686 |
+----------------------+-----------+--------------------+

[tstromberg]

Flakes are troubling, but unrelated:

• none failed at FAIL: TestAddons/parallel/Registry. TestAddons/parallel/Registry failing on none: wget: bad address 'registry.kube-system.svc.cluster.local' #5926
• KVM failed at TestStartStop/group/cni with machine didn't return an IP after 120 seconds. KVM integration tests failing with "machine didn't return an IP after 120 seconds" #5927
• HyperKit failed with IP address never found in dhcp leases file
• Hyper-V failed with pod "integration-test=busybox" failed to start within 4m0s: timed out waiting for the condition, which reports:

Ready False Fri, 15 Nov 2019 11:31:37 -0800 Fri, 15 Nov 2019 11:28:10 -0800 KubeletNotReady [container runtime is down, PLEG is not healthy: pleg was last seen active 3m59.182531534s ago; threshold is 3m0s]

• VirtualBox failed due to running out of time: