Update docker to v19.03.5 #5914

harsimranmaan · 2019-11-14T20:02:36Z

Resolves #5913
fixes #5913

k8s-ci-robot · 2019-11-14T20:02:39Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2019-11-14T20:02:44Z

Welcome @harsimranmaan!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2019-11-14T20:02:44Z

Hi @harsimranmaan. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

minikube-bot · 2019-11-14T20:03:04Z

Can one of the admins verify this patch?

k8s-ci-robot · 2019-11-14T20:03:16Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: harsimranmaan
To complete the pull request process, please assign afbjorklund
You can assign the PR to them by writing /assign @afbjorklund in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

harsimranmaan · 2019-11-14T20:07:34Z

/assign @afbjorklund

codecov-io · 2019-11-14T20:09:08Z

Codecov Report

Merging #5914 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5914   +/-   ##
=======================================
  Coverage   36.13%   36.13%           
=======================================
  Files         110      110           
  Lines        8200     8200           
=======================================
  Hits         2963     2963           
  Misses       4846     4846           
  Partials      391      391

tstromberg · 2019-11-14T20:10:16Z

/ok-to-test

afbjorklund · 2019-11-15T06:53:54Z

Note that Docker 19.03 is not officially supported until 1.17

afbjorklund · 2019-11-15T06:54:58Z

Also need to update containerd and runc (normally bundled together)

minikube-bot · 2019-11-15T18:30:17Z

All Times minikube: [ 129.809276 126.362968 127.865162]
All Times Minikube (PR 5914): [ 130.942510 115.518878 127.415398]

Average minikube: 128.012468
Average Minikube (PR 5914): 124.625595

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 5914) |
+----------------------+-----------+--------------------+
| minikube v           |  0.344022 |           0.346273 |
| Creating kvm2        | 41.551641 |          41.619655 |
| Preparing Kubernetes | 55.799204 |          51.377154 |
| Pulling images       |  2.713374 |           2.736640 |
| Launching Kubernetes | 19.970395 |          20.268353 |
| Waiting for cluster  |  7.582620 |           8.227218 |
+----------------------+-----------+--------------------+

afbjorklund · 2019-11-15T18:36:52Z

Note that docker 19.03.5 uses containerd v1.2.10-0-gb34a5c8 and runc v1.0.0-rc8-91-g3e425f8

harsimranmaan · 2019-11-15T19:14:59Z

Note that docker 19.03.5 uses containerd v1.2.10-0-gb34a5c8 and runc v1.0.0-rc8-91-g3e425f8

I downgraded containerd to v1.12.10. I have kept runc at rc9 instead of rc8 as it has the fix for https://nvd.nist.gov/vuln/detail/CVE-2019-16884

minikube-bot · 2019-11-15T19:27:15Z

All Times Minikube (PR 5914): [ 133.044777 134.271933 131.768189]
All Times minikube: [ 130.799644 134.321091 130.013189]

Average Minikube (PR 5914): 133.028300
Average minikube: 131.711308

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 5914) |
+----------------------+-----------+--------------------+
| minikube v           |  0.348351 |           0.366234 |
| Creating kvm2        | 42.347753 |          43.859419 |
| Preparing Kubernetes | 56.588807 |          55.981747 |
| Pulling images       |  2.759854 |           2.754195 |
| Launching Kubernetes | 21.853309 |          22.438433 |
| Waiting for cluster  |  7.762118 |           7.575186 |
+----------------------+-----------+--------------------+

tstromberg · 2019-11-20T18:33:21Z

The build is currently failing due to an issue downloading the runc version you specified:

>>> podman v1.4.4 Installing to target
/usr/bin/install -Dm755 /var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/build/podman-v1.4.4/bin/podman /var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/target/usr/bin/podman
>>> runc-master d736ef14f0288d6993a1845745d6756cfc9ddd5a Downloading
--2019-11-15 11:59:17--  https://github.com/opencontainers/runc/archive/d736ef14f0288d6993a1845745d6756cfc9ddd5a.tar.gz
Resolving github.com (github.com)... 140.82.113.4
Connecting to github.com (github.com)|140.82.113.4|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://codeload.github.com/opencontainers/runc/tar.gz/d736ef14f0288d6993a1845745d6756cfc9ddd5a [following]
--2019-11-15 11:59:17--  https://codeload.github.com/opencontainers/runc/tar.gz/d736ef14f0288d6993a1845745d6756cfc9ddd5a
Resolving codeload.github.com (codeload.github.com)... 140.82.113.9
Connecting to codeload.github.com (codeload.github.com)|140.82.113.9|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [application/x-gzip]
Saving to: ‘/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/build/.d736ef14f0288d6993a1845745d6756cfc9ddd5a.tar.gz.t4hovR/output’

     0K .......... .......... .......... .......... ..........  607K
    50K .......... .......... .......... .......... .......... 1.70M
   100K .......... .......... .......... .......... .......... 46.6M
   150K .......... .......... .......... .......... .......... 1.77M
   200K .......... .......... .......... .......... .......... 46.5M
   250K .......... .......... .......... .......... .......... 47.9M
   300K .......... .......... .......... .......... .......... 1.77M
   350K .......... .......... .......... .......... .......... 46.6M
   400K .......... .......... .......... .......... .......... 48.8M
   450K .......... .......... .......... .......... .......... 46.3M
   500K .......... .......... .......... .......... .......... 49.0M
   550K .......... .......... .......... .......... .......... 2.08M
   600K .......... .......... .......... .......... .......... 89.1M
   650K .......... .......... .......... .......... ..........  124M
   700K .......... .......... .......... .......... .......... 46.3M
   750K .......... .......... .......... .......... .......... 39.6M
   800K .......... .......... .......... .......... .......... 48.1M
   850K .......... .......... .......... .......... .......... 47.8M
   900K .......... .......... .......... .......... .......... 46.8M
   950K .......... .......... .......... .......... .......... 46.9M
  1000K .......... .......... .......... .......... .......... 47.5M
  1050K .......... .......... .......... .......... .......... 46.0M
  1100K .......... .......... .......... .......... .......... 2.44M
  1150K .......... .......... .......... .......... .......... 33.0M
  1200K .......... .......... .......... .......... .......... 47.0M
  1250K .......... .......... .......... .......... .......... 5.79M
  1300K .......... .......... .......... .......... .......... 4.89M
  1350K .......... .......... .......... .......... .......... 41.6M
  1400K .......... .......... .......... .......... .......... 5.66M
  1450K .......... .......... .......... .......... .......... 4.79M
  1500K .......... .......... .......... .......... .......... 5.85M
  1550K .......... .......... .......... .......... .......... 5.80M
  1600K .......... .......... .......... .......... .......... 6.23M
  1650K .......... .......... .......... .......... .......... 5.22M
  1700K .......... .......... .......... .......... .......... 4.96M
  1750K .......... .......... .......... .......... .......... 7.10M
  1800K .......... .......... .......... ..........            33.9M=0.3s

2019-11-15 11:59:18 (5.63 MB/s) - ‘/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/build/.d736ef14f0288d6993a1845745d6756cfc9ddd5a.tar.gz.t4hovR/output’ saved [1885161]

ERROR: d736ef14f0288d6993a1845745d6756cfc9ddd5a.tar.gz has wrong sha256 hash:
ERROR: expected: 2ec69c25df9f02c6fd38eb287145f8afba6772f809abe01df4534b5bfd68e8d4
ERROR: got     : 4ffe8323397d85dda7d5875fa6bdaf3f8c93592c1947dfa24a034719dc6f728e
ERROR: Incomplete download, or man-in-the-middle (MITM) attack
--2019-11-15 11:59:18--  http://sources.buildroot.net/runc-master/d736ef14f0288d6993a1845745d6756cfc9ddd5a.tar.gz
Resolving sources.buildroot.net (sources.buildroot.net)... 104.26.1.37, 104.26.0.37, 2606:4700:20::681a:125, ...
Connecting to sources.buildroot.net (sources.buildroot.net)|104.26.1.37|:80... connected.
HTTP request sent, awaiting response... 404 Not Found
2019-11-15 11:59:18 ERROR 404: Not Found.

--2019-11-15 11:59:18--  http://sources.buildroot.net/d736ef14f0288d6993a1845745d6756cfc9ddd5a.tar.gz
Resolving sources.buildroot.net (sources.buildroot.net)... 104.26.1.37, 104.26.0.37, 2606:4700:20::681a:125, ...
Connecting to sources.buildroot.net (sources.buildroot.net)|104.26.1.37|:80... connected.
HTTP request sent, awaiting response... 404 Not Found
2019-11-15 11:59:18 ERROR 404: Not Found.

This may be a simple hash mismatch. Do you mind taking a closer look?

harsimranmaan · 2019-11-20T21:18:17Z

Thanks @tstromberg. It was a hash mismatch

minikube-bot · 2019-11-20T22:17:17Z

All Times minikube: [ 144.377754 141.300781 148.345230]
All Times Minikube (PR 5914): [ 129.853256 129.554628 134.913755]

Average minikube: 144.674588
Average Minikube (PR 5914): 131.440547

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 5914) |
+----------------------+-----------+--------------------+
| minikube v           |  0.362377 |           0.375450 |
| Creating kvm2        | 43.912632 |          45.016707 |
| Preparing Kubernetes | 55.062752 |          54.422792 |
| Pulling images       | 16.232311 |           2.154151 |
| Launching Kubernetes | 21.272770 |          21.502569 |
| Waiting for cluster  |  7.772850 |           7.913911 |
+----------------------+-----------+--------------------+

afbjorklund · 2019-11-23T10:20:30Z

I think we should use the same version of runc that docker does...

I can take this task, but want to upgrade podman and crio as well.

afbjorklund · 2019-11-23T10:22:10Z

I have kept runc at rc9 instead of rc8

Note that it wasn't v1.0.0-rc8 itself.

EDIT: My bad, it was not in docker-19.03.5
i.e. the fix is only included in v1.0.0-rc9

v1.0.0-rc8-95-gcad42f6 (opencontainers/runc@cad42f6)

k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Nov 14, 2019

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 14, 2019

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 14, 2019

k8s-ci-robot requested review from afbjorklund and tstromberg November 14, 2019 20:02

Update docker to v19.03.5

7f77af5

harsimranmaan force-pushed the update_docker branch from 0355b4f to 7f77af5 Compare November 14, 2019 20:06

k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Nov 14, 2019

k8s-ci-robot assigned afbjorklund Nov 14, 2019

Update containerd and runc

cdc0a38

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 15, 2019

Use same containerd as docker

63ab594

Update runc hash

f486f96

afbjorklund approved these changes Nov 25, 2019

View reviewed changes

medyagh merged commit 8431207 into kubernetes:master Nov 25, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update docker to v19.03.5 #5914

Update docker to v19.03.5 #5914

harsimranmaan commented Nov 14, 2019

k8s-ci-robot commented Nov 14, 2019

k8s-ci-robot commented Nov 14, 2019

k8s-ci-robot commented Nov 14, 2019

minikube-bot commented Nov 14, 2019

k8s-ci-robot commented Nov 14, 2019

harsimranmaan commented Nov 14, 2019

codecov-io commented Nov 14, 2019

tstromberg commented Nov 14, 2019

afbjorklund commented Nov 15, 2019

afbjorklund commented Nov 15, 2019 •

edited

Loading

minikube-bot commented Nov 15, 2019

afbjorklund commented Nov 15, 2019 •

edited

Loading

harsimranmaan commented Nov 15, 2019

minikube-bot commented Nov 15, 2019

tstromberg commented Nov 20, 2019 •

edited

Loading

harsimranmaan commented Nov 20, 2019

minikube-bot commented Nov 20, 2019

afbjorklund commented Nov 23, 2019

afbjorklund commented Nov 23, 2019 •

edited

Loading

Update docker to v19.03.5 #5914

Update docker to v19.03.5 #5914

Conversation

harsimranmaan commented Nov 14, 2019

k8s-ci-robot commented Nov 14, 2019

k8s-ci-robot commented Nov 14, 2019

k8s-ci-robot commented Nov 14, 2019

minikube-bot commented Nov 14, 2019

k8s-ci-robot commented Nov 14, 2019

harsimranmaan commented Nov 14, 2019

codecov-io commented Nov 14, 2019

Codecov Report

tstromberg commented Nov 14, 2019

afbjorklund commented Nov 15, 2019

afbjorklund commented Nov 15, 2019 • edited Loading

minikube-bot commented Nov 15, 2019

afbjorklund commented Nov 15, 2019 • edited Loading

harsimranmaan commented Nov 15, 2019

minikube-bot commented Nov 15, 2019

tstromberg commented Nov 20, 2019 • edited Loading

harsimranmaan commented Nov 20, 2019

minikube-bot commented Nov 20, 2019

afbjorklund commented Nov 23, 2019

afbjorklund commented Nov 23, 2019 • edited Loading

afbjorklund commented Nov 15, 2019 •

edited

Loading

afbjorklund commented Nov 15, 2019 •

edited

Loading

tstromberg commented Nov 20, 2019 •

edited

Loading

afbjorklund commented Nov 23, 2019 •

edited

Loading