-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor config.Config to prepare for multinode #5889
Refactor config.Config to prepare for multinode #5889
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sharifelgamal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #5889 +/- ##
==========================================
- Coverage 36.47% 36.44% -0.04%
==========================================
Files 110 110
Lines 8159 8161 +2
==========================================
- Hits 2976 2974 -2
- Misses 4794 4796 +2
- Partials 389 391 +2
|
/ok-to-test |
Error: building minikube at head: updating minikube master branch: running [git pull origin master] in /home/performance-monitor/minikube: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might not be perfect, but it's a start!
Note: we'll eventually have to deal with supporting configs in the old style, but for now this will do. |
This PR allows a profile to have multiple MachineConfigs, to account for multiple nodes in a cluster. It also inlines KubernetesConfig under MachineConfig, so that each node in a multinode cluster can have its own k8s config.