-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update libmachine to point to latest #5877
Update libmachine to point to latest #5877
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sharifelgamal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Travis tests have failedHey @sharifelgamal, TravisBuddy Request Identifier: 8502c610-032b-11ea-bbb5-2bfb3cbbfe32 |
Codecov Report
@@ Coverage Diff @@
## master #5877 +/- ##
======================================
Coverage 36.5% 36.5%
======================================
Files 110 110
Lines 8123 8123
======================================
Hits 2965 2965
Misses 4769 4769
Partials 389 389 |
/ok-to-test |
All Times minikube: [ 178.251057 205.603872 195.463200] Average minikube: 193.106043 Averages Time Per Log
|
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird with all those random changes in go.mod, just for changing some code in libmachine...
Yeah I'm not sure what's going on with go.mod, those 3 modules get added every time I run |
Should hopefully fix #4802