Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent minikube from crashing if namespace or service doesn't exist #5844

Merged
merged 6 commits into from
Mar 21, 2020
Merged

Prevent minikube from crashing if namespace or service doesn't exist #5844

merged 6 commits into from
Mar 21, 2020

Commits on Mar 7, 2020

  1. Updated error handling when service or namespace doesn't exist

    @rajula96reddy
    rajula96reddy authored and Vineet Rajula (vrajula) committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    5a32eb7 View commit details
    Browse the repository at this point in the history

  2. Formatted the error output

    @rajula96reddy
    rajula96reddy authored and Vineet Rajula (vrajula) committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    061b159 View commit details
    Browse the repository at this point in the history

  3. Modified the previous commit using Erros.New() function

    @rajula96reddy
    rajula96reddy authored and Vineet Rajula (vrajula) committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    8b22898 View commit details
    Browse the repository at this point in the history

  4. Created new error type & made corresponding changes

    @rajula96reddy
    rajula96reddy authored and Vineet Rajula (vrajula) committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    40c1c80 View commit details
    Browse the repository at this point in the history

  5. Modified 'checking if service exists before retry' logic

    @rajula96reddy
    rajula96reddy authored and Vineet Rajula (vrajula) committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    5d8d3f0 View commit details
    Browse the repository at this point in the history

  6. Deleted unnecessary comments

    @rajula96reddy
    rajula96reddy authored and Vineet Rajula (vrajula) committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    3ffdaf3 View commit details
    Browse the repository at this point in the history