Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cron script installation #5813

Merged
merged 1 commit into from
Nov 4, 2019
Merged

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented Nov 1, 2019

to fix the errors I see on master integration tests for linux vbox

08:57:25 Operation completed over 2 objects/2.9 KiB.                                      
08:57:26 install: cannot stat 'cleanup_and_reboot_Linux.sh': No such file or directory
08:57:26 Build step 'Execute shell' marked build as failure
08:57:42 [Google Cloud Storage Plugin] Uploading: VirtualBox_Linux.txt
08:57:42 Finished: FAILURE

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 1, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2019
@medyagh
Copy link
Member Author

medyagh commented Nov 1, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 1, 2019
@medyagh medyagh changed the title fix cron cleanup script fix cron script installation Nov 1, 2019
@tstromberg
Copy link
Contributor

Do you mind providing an example?

It isn't clear what this fixes. If you can't mkdir cron, mkdir -p cron won't work either.

@medyagh
Copy link
Member Author

medyagh commented Nov 1, 2019

Do you mind providing an example?

It isn't clear what this fixes. If you can't mkdir cron, mkdir -p cron won't work either.

the problem is all other scripts, kvm, none,... have cron/cleanup_and_reboot_Linux.sh
but the virtualbox has cleanup_and_reboot_Linux.sh, it is missing "cron/"

I added the -p basicly to be same command as other ones, (the other ones have -p)

@medyagh
Copy link
Member Author

medyagh commented Nov 1, 2019

Currently all the linbux vbox on master are broken with the following log:

cannot stat 'cleanup_and_reboot_Linux.sh': No such file or directory

Screen Shot 2019-11-01 at 3 44 09 PM

@medyagh
Copy link
Member Author

medyagh commented Nov 3, 2019

/retest this please

@medyagh medyagh merged commit 488271c into kubernetes:master Nov 4, 2019
@medyagh medyagh deleted the clean_cron branch November 4, 2019 18:16
@medyagh
Copy link
Member Author

medyagh commented Nov 4, 2019

KVM failedure crio is related to this :

#5723

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants