Fix pod list retry, reset start timer #5794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/XS
medyagh
added
the
ok-to-test
sharifelgamal
approved these changes
Oct 30, 2019
medyagh
approved these changes
Oct 30, 2019
|
Related: #5795 |
|
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## master #5794 +/- ##
=======================================
Coverage 36.62% 36.62%
=======================================
Files 110 110
Lines 8093 8093
=======================================
Hits 2964 2964
Misses 4740 4740
Partials 389 389 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because pod.List was returning an error, it wasn't being retried.
Addresses issue seen on https://storage.googleapis.com/minikube-builds/logs/5790/none_Linux.txt - where the apiserver may be restarting with the none driver when calling start/stop.