gvisor: Use chroot instead of LD_LIBRARY_PATH #5735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
medyagh
approved these changes
Oct 25, 2019
tstromberg
changed the title
Codecov Report
@@ Coverage Diff @@
## master #5735 +/- ##
=======================================
Coverage 37.83% 37.83%
=======================================
Files 106 106
Lines 7773 7773
=======================================
Hits 2941 2941
Misses 4452 4452
Partials 380 380 |
|
@minikube-bot OK to test |
priyawadhwa
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces brittle
LD_LIBRARY_PATHhack withchrootto restart node services from the pod.This was previously using the Ubuntu
sudobinary with libraries from the ISO image, which was safe until we updated the ISO image to a new glibc.Fixes #5724