Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to override autoupdating drivers #5640

Merged
merged 4 commits into from
Oct 21, 2019

Conversation

sharifelgamal
Copy link
Collaborator

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2019
@codecov-io
Copy link

codecov-io commented Oct 16, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@a84b3a9). Click here to learn what that means.
The diff coverage is 8.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5640   +/-   ##
=========================================
  Coverage          ?   37.83%           
=========================================
  Files             ?      103           
  Lines             ?     7591           
  Branches          ?        0           
=========================================
  Hits              ?     2872           
  Misses            ?     4342           
  Partials          ?      377
Impacted Files Coverage Δ
pkg/drivers/drivers.go 8.39% <0%> (ø)
cmd/minikube/cmd/start.go 22.24% <16.66%> (ø)

@tstromberg tstromberg merged commit 523db20 into kubernetes:master Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants