jenkins: Resilient VirtualBox VM and test directory cleanup

[tstromberg]

• Make sure that "list vms" regex only matches guid portion
• Add logging
• unregistervm still called if startvm fails

Related: #5583

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tstromberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov-io]

Codecov Report

Merging #5584 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5584   +/-   ##
=======================================
  Coverage   36.86%   36.86%           
=======================================
  Files         102      102           
  Lines        7349     7349           
=======================================
  Hits         2709     2709           
  Misses       4289     4289           
  Partials      351      351

[tstromberg]

It seems like our script is eating it on wildcards, though I don't see set -f open. Will make the script work in this case:

>> Cleaning up after previous test runs ...
* Cleaning stale test root: /Users/jenkins/minikube-integration/*
find: /Users/jenkins/minikube-integration/*: No such file or directory
find: /Users/jenkins/minikube-integration/*: No such file or directory
find: /Users/jenkins/minikube-integration/*: No such file or directory
rmdir: /Users/jenkins/minikube-integration/*: No such file or directory
ls: /Users/jenkins/minikube-integration/*: No such file or directory
Build step 'Execute shell' marked build as failure

[tstromberg]

This now removes the following out of the jenkins config:

vboxmanage list -l hostonlyifs | grep -w "Name:" | awk '{$1=""; print $0}' | xargs -l vboxmanage hostonlyif remove || true

as it was creating the following error:

+ vboxmanage list -l hostonlyifs
+ grep -w Name:
+ awk '{$1=""; print $0}'
+ xargs -l vboxmanage hostonlyif remove
Oracle VM VirtualBox Command Line Management Interface Version 5.2.18
(C) 2005-2018 Oracle Corporation
All rights reserved.

Usage:

VBoxManage hostonlyif       ipconfig <name>
                            [--dhcp |
                            --ip<ipv4> [--netmask<ipv4> (def: 255.255.255.0)] |
                            --ipv6<ipv6> [--netmasklengthv6<length> (def: 64)]]
                            create |
                            remove <name>


Syntax error: No interface name was specified

[medyagh]

one thing I noitced in vboxmanage list is, the order of columns changes, if the VM is "inaccessible".
that why I had I to do this: c5111ef

(probably not related to your PR) but when putting regex on vbox manage, thats something I would be mindful of .