Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libmachine debug logs back #5574

Merged
merged 4 commits into from
Oct 9, 2019
+4 −1
Merged

Add libmachine debug logs back #5574

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
994606c
Add libmachine debug logs back
sharifelgamal Oct 9, 2019
dc0240a
remove unnecessary call
sharifelgamal Oct 9, 2019
946afc5
pointless import
sharifelgamal Oct 9, 2019
e15c725
revert unrelated changes
sharifelgamal Oct 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cmd/minikube/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,9 @@ import (
const minikubeEnableProfile = "MINIKUBE_ENABLE_PROFILING"

var (
machineLogErrorRe = regexp.MustCompile(`(?i) (failed|error|fatal)`)
// This regex is intentionally very specific, it's supposed to surface
// unexpected errors from libmachine to the user.
machineLogErrorRe = regexp.MustCompile(`VirtualizationException`)
machineLogWarningRe = regexp.MustCompile(`(?i)warning`)
)

Expand All @@ -67,6 +69,7 @@ func bridgeLogMessages() {
log.SetOutput(stdLogBridge{})
mlog.SetErrWriter(machineLogBridge{})
mlog.SetOutWriter(machineLogBridge{})
mlog.SetDebug(true)
}

type stdLogBridge struct{}
Expand Down