-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instructions for including supporting documents with MEP proposal #5542
Add instructions for including supporting documents with MEP proposal #5542
Conversation
Hi @woodcockjosh. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: woodcockjosh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Travis tests have failedHey @woodcockjosh, 1st Buildmake test
TravisBuddy Request Identifier: cebe7c50-e6b5-11e9-9927-991e8c29daea |
Codecov Report
@@ Coverage Diff @@
## master #5542 +/- ##
=======================================
Coverage 36.89% 36.89%
=======================================
Files 102 102
Lines 7369 7369
=======================================
Hits 2719 2719
Misses 4297 4297
Partials 353 353 |
/ok-to-test |
86c0de5
to
4486abc
Compare
4486abc
to
d0a7f19
Compare
Error: running mkcmp: exit status 1 |
This changes instructions so that supporting documents may optionally be included as part of a minikube enhancement process (MEP) proposal.
/assign @tstromberg