Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint travis.yml #5536

Merged
merged 2 commits into from
Oct 7, 2019
Merged

lint travis.yml #5536

merged 2 commits into from
Oct 7, 2019

Conversation

n0npax
Copy link
Contributor

@n0npax n0npax commented Oct 3, 2019

improve yaml syntax

fix yaml aligment
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 3, 2019
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 3, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @n0npax. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 3, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: n0npax
To complete the pull request process, please assign medyagh
You can assign the PR to them by writing /assign @medyagh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-io
Copy link

codecov-io commented Oct 3, 2019

Codecov Report

Merging #5536 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5536   +/-   ##
=======================================
  Coverage   36.63%   36.63%           
=======================================
  Files         102      102           
  Lines        7346     7346           
=======================================
  Hits         2691     2691           
  Misses       4298     4298           
  Partials      357      357
Impacted Files Coverage Δ
pkg/minikube/assets/addons.go 36.66% <0%> (ø) ⬆️
cmd/minikube/cmd/config/config.go 10.41% <0%> (ø) ⬆️

@n0npax n0npax changed the title improve syntax in .travis.yaml [WIP] improve syntax in .travis.yaml Oct 3, 2019
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 3, 2019
@TravisBuddy
Copy link

Travis tests have failed

Hey @n0npax,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

black ./hack --check
would reformat /home/travis/build/kubernetes/minikube/hack/get_k8s_version.py
would reformat /home/travis/build/kubernetes/minikube/hack/boilerplate/boilerplate.py
would reformat /home/travis/build/kubernetes/minikube/hack/prow/run_tests.py
All done! 💥 💔 💥
3 files would be reformatted.
travis_time:end:03621792:start=1570105127045635427,finish=1570105127687667311,duration=642031884,event=script
TravisBuddy Request Identifier: 88fd2960-e5d8-11e9-82e3-2501c7641175

@n0npax n0npax closed this Oct 3, 2019
@TravisBuddy
Copy link

Travis tests have failed

Hey @n0npax,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

black ./hack --check
would reformat /home/travis/build/kubernetes/minikube/hack/get_k8s_version.py
would reformat /home/travis/build/kubernetes/minikube/hack/boilerplate/boilerplate.py
would reformat /home/travis/build/kubernetes/minikube/hack/prow/run_tests.py
All done! 💥 💔 💥
3 files would be reformatted.
travis_time:end:17b98eaa:start=1570105388726686512,finish=1570105389351010687,duration=624324175,event=script
TravisBuddy Request Identifier: 51d7c570-e5d9-11e9-82e3-2501c7641175

@n0npax n0npax changed the title [WIP] improve syntax in .travis.yaml improve syntax in .travis.yaml Oct 3, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 3, 2019
@n0npax n0npax changed the title improve syntax in .travis.yaml https://github.com/kubernetes/minikube/pull/5537 Oct 3, 2019
@n0npax n0npax deleted the yamllint-on-travis-file branch October 3, 2019 13:02
@n0npax n0npax reopened this Oct 3, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 3, 2019
@n0npax n0npax changed the title https://github.com/kubernetes/minikube/pull/5537 fix linting for travis.yml Oct 3, 2019
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 3, 2019
@medyagh
Copy link
Member

medyagh commented Oct 7, 2019

@n0npax could you please specify the tool you used to lint the yaml file ? It would be nice to add a comment in the yaml file for future editors to make sure they pass a specific yaml format

@n0npax
Copy link
Contributor Author

n0npax commented Oct 7, 2019

Added info about yamllint to file as requested

@medyagh
Copy link
Member

medyagh commented Oct 7, 2019

Thank you for improving the code readability.

@medyagh medyagh merged commit 33b6547 into kubernetes:master Oct 7, 2019
@medyagh medyagh changed the title fix linting for travis.yml lint travis.yml Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants