Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor command runner interface, allow stdin writes #5530

Merged
merged 62 commits into from
Oct 30, 2019
Merged

Refactor command runner interface, allow stdin writes #5530

merged 62 commits into from
Oct 30, 2019

Commits on Oct 2, 2019

  1. implementing new interface RunCmd for exec_runner & fake_runner

    @medyagh
    medyagh committed Oct 2, 2019
    Configuration menu
    Copy the full SHA
    809389c View commit details
    Browse the repository at this point in the history

  2. move teePrefix from util to ssh_runner

    @medyagh
    medyagh committed Oct 2, 2019
    Configuration menu
    Copy the full SHA
    8818324 View commit details
    Browse the repository at this point in the history

  3. move unit tests from util to command_runner

    @medyagh
    medyagh committed Oct 2, 2019
    Configuration menu
    Copy the full SHA
    eaa0171 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2019

  1. fix format type

    @medyagh
    medyagh committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    2f276e2 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2019

  1. add ExecCmd and convert kubeadm,cert to new interface

    @medyagh
    medyagh committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    27321d5 View commit details
    Browse the repository at this point in the history

  2. fixing fake_runner for interface

    @medyagh
    medyagh committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    36de216 View commit details
    Browse the repository at this point in the history

  3. remove extra error wrap

    @medyagh
    medyagh committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    c7af9e7 View commit details
    Browse the repository at this point in the history

  4. improve error wrap

    @medyagh
    medyagh committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    4644207 View commit details
    Browse the repository at this point in the history

  5. travis buddy to only return error

    @medyagh
    medyagh committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    52dc6ad View commit details
    Browse the repository at this point in the history

  6. travis-buddy config

    @medyagh
    medyagh committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    12fab35 View commit details
    Browse the repository at this point in the history

  7. travisbuddy tweak

    @medyagh
    medyagh committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    a6cf688 View commit details
    Browse the repository at this point in the history

  8. tweak travisbuddy regex

    @medyagh
    medyagh committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    723f62c View commit details
    Browse the repository at this point in the history

  9. tweak travisbuddy regex again

    @medyagh
    medyagh committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    d75f417 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2019

  1. fix formatting

    @medyagh
    medyagh committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    7709c77 View commit details
    Browse the repository at this point in the history

  2. fix fakerunner runcmd unit test

    @medyagh
    medyagh committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    9df5618 View commit details
    Browse the repository at this point in the history

  3. refactor

    @medyagh
    medyagh committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    8fcdae9 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2019

  1. adding a new ExecCmd2

    @medyagh
    medyagh committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    a78deab View commit details
    Browse the repository at this point in the history

  2. fix unit test for cert

    @medyagh
    medyagh committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    0c435b0 View commit details
    Browse the repository at this point in the history

  3. move more to exec.Cmd2

    @medyagh
    medyagh committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    b8181a0 View commit details
    Browse the repository at this point in the history

  4. get rid of ExecCmd2

    @medyagh
    medyagh committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    9271463 View commit details
    Browse the repository at this point in the history

  5. get rid of ExecCmd all the way

    @medyagh
    medyagh committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    91618aa View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2019

  1. fixing with shelquote

    @medyagh
    medyagh committed Oct 9, 2019
    Configuration menu
    Copy the full SHA
    25e3d87 View commit details
    Browse the repository at this point in the history

  2. fix unit test for cert

    @medyagh
    medyagh committed Oct 9, 2019
    Configuration menu
    Copy the full SHA
    83f736d View commit details
    Browse the repository at this point in the history

  3. shellquoting more

    @medyagh
    medyagh committed Oct 9, 2019
    Configuration menu
    Copy the full SHA
    da5cae6 View commit details
    Browse the repository at this point in the history

  4. fix

    @medyagh
    medyagh committed Oct 9, 2019
    Configuration menu
    Copy the full SHA
    79e65c1 View commit details
    Browse the repository at this point in the history

  5. refactor more

    @medyagh
    medyagh committed Oct 9, 2019
    Configuration menu
    Copy the full SHA
    7109b22 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2019

  1. move everything to RunCmd

    @medyagh
    medyagh committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    57ac160 View commit details
    Browse the repository at this point in the history

  2. bin bash all the way

    @medyagh
    medyagh committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    fcf17fb View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into NewCmdRunner

    @medyagh
    medyagh committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    f8b38d2 View commit details
    Browse the repository at this point in the history

  4. fix some lint nad test

    @medyagh
    medyagh committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    466123a View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2019

  1. fix more commands to bin bash

    @medyagh
    medyagh committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    c71b677 View commit details
    Browse the repository at this point in the history

  2. add unit test for cmdToStr

    @medyagh
    medyagh committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    eac0220 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2019

  1. fix more stuf

    @medyagh
    medyagh committed Oct 12, 2019
    Configuration menu
    Copy the full SHA
    3909925 View commit details
    Browse the repository at this point in the history

  2. adding a logging to make sure jenkins is running right thing

    @medyagh
    medyagh committed Oct 12, 2019
    Configuration menu
    Copy the full SHA
    749c34a View commit details
    Browse the repository at this point in the history

  3. printing minikube version and commit id before test

    @medyagh
    medyagh committed Oct 12, 2019
    Configuration menu
    Copy the full SHA
    1da56c5 View commit details
    Browse the repository at this point in the history

  4. echo minikube version in integration script

    @medyagh
    medyagh committed Oct 12, 2019
    Configuration menu
    Copy the full SHA
    5c9d98f View commit details
    Browse the repository at this point in the history

  5. add minikube binary version

    @medyagh
    medyagh committed Oct 12, 2019
    Configuration menu
    Copy the full SHA
    a7de6c7 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2019

  1. fix unit test, remove mount fake runner

    @medyagh
    medyagh committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    aace212 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2019

  1. fixing logs

    @medyagh
    medyagh committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    74b7054 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2019

  1. fix stdout,stderr

    @medyagh
    medyagh committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    48cd862 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into NewCmdRunner

    @medyagh
    medyagh committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    6bd5d9b View commit details
    Browse the repository at this point in the history

  3. convert more to exec.Command

    @medyagh
    medyagh committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    342397a View commit details
    Browse the repository at this point in the history

  4. lint and code review

    @medyagh
    medyagh committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    6faf9cd View commit details
    Browse the repository at this point in the history

  5. trying to fix logs

    @medyagh
    medyagh committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    6e1c4f6 View commit details
    Browse the repository at this point in the history

  6. remove uneeded wrap output

    @medyagh
    medyagh committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    05bbcf7 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2019

  1. fixing pointer and teeSSH

    @medyagh
    medyagh committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    45e5beb View commit details
    Browse the repository at this point in the history

  2. Fixing pointer and unit test

    @medyagh
    medyagh committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    900123b View commit details
    Browse the repository at this point in the history

  3. makefile conflict

    @medyagh
    medyagh committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    415f0ca View commit details
    Browse the repository at this point in the history

  4. getting rid of some of bin bash -c

    @medyagh
    medyagh committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    187dfe2 View commit details
    Browse the repository at this point in the history

  5. remove extra error word

    @medyagh
    medyagh committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    ddabc9e View commit details
    Browse the repository at this point in the history

  6. fix unit test and remove more bin bash c

    @medyagh
    medyagh committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    0d8c894 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2019

  1. removed more bin bash calls

    @medyagh
    medyagh committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    01573e4 View commit details
    Browse the repository at this point in the history

  2. Fix exec runner and remove some debug logging

    @medyagh
    medyagh committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    69dba7c View commit details
    Browse the repository at this point in the history

  3. change shellquote to args

    @medyagh
    medyagh committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    291731c View commit details
    Browse the repository at this point in the history

  4. fix none docker test

    @medyagh
    medyagh committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    592ea15 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2019

  1. resolve code review

    @medyagh
    medyagh committed Oct 26, 2019
    Configuration menu
    Copy the full SHA
    792de2b View commit details
    Browse the repository at this point in the history

  2. fix unit test

    @medyagh
    medyagh committed Oct 26, 2019
    Configuration menu
    Copy the full SHA
    1b834df View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2019

  1. Merge branch 'master' into NewCmdRunner

    @medyagh
    medyagh authored Oct 27, 2019
    Configuration menu
    Copy the full SHA
    e2bbf71 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2019

  1. remove more bin bash c

    @medyagh
    medyagh committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    29a015b View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2019

  1. resolve code review

    @medyagh
    medyagh committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    cd9e413 View commit details
    Browse the repository at this point in the history

  2. fix test and remove extra code

    @medyagh
    medyagh committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    773c525 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2019

  1. resolve conflict

    @medyagh
    medyagh committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    77ccd46 View commit details
    Browse the repository at this point in the history