Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pods not being scheduled when ingress deployment is patched #5519

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Fix pods not being scheduled when ingress deployment is patched #5519

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion deploy/addons/ingress/ingress-dp.yaml.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,12 @@ metadata:
addonmanager.kubernetes.io/mode: Reconcile
spec:
replicas: 1
strategy:
type: RollingUpdate
rollingUpdate:
# maxUnavailable needs to be 1 so that port conflicts between the old and new pod doesn't happen when using hostPort
maxUnavailable: 1
maxSurge: 1
selector:
matchLabels:
app.kubernetes.io/name: nginx-ingress-controller
Expand All @@ -42,7 +48,7 @@ spec:
serviceAccountName: nginx-ingress
terminationGracePeriodSeconds: 60
containers:
- image: quay.io/kubernetes-ingress-controller/nginx-ingress-controller{{.ExoticArch}}:0.25.1
- image: quay.io/kubernetes-ingress-controller/nginx-ingress-controller{{.ExoticArch}}:0.26.1
name: nginx-ingress-controller
imagePullPolicy: IfNotPresent
readinessProbe:
Expand Down