Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting travis-ci notification settings explicitly #5475

Merged
merged 1 commit into from
Sep 26, 2019

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented Sep 26, 2019

To make sure the travis-buddy comments only on failed builds and not make noise when things are okay ! seems like it is a travis-ci issue not respecting the "never" bluzi/travis-buddy#153

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 26, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2019
@medyagh medyagh changed the title set notification settings travis-ci explicit notification settings for travis-ci Sep 26, 2019
@codecov-io
Copy link

Codecov Report

Merging #5475 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5475   +/-   ##
=======================================
  Coverage   36.56%   36.56%           
=======================================
  Files         102      102           
  Lines        7319     7319           
=======================================
  Hits         2676     2676           
  Misses       4292     4292           
  Partials      351      351

@medyagh medyagh changed the title explicit notification settings for travis-ci Setting notification settings for travis-ci explicitly Sep 26, 2019
@medyagh medyagh changed the title Setting notification settings for travis-ci explicitly Setting travis-ci notification settings explicitly Sep 26, 2019
@tstromberg tstromberg merged commit 7f68b83 into kubernetes:master Sep 26, 2019
@medyagh medyagh deleted the travis_notfiy branch September 26, 2019 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants