Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use existing driver by default, improve driver conflict message #5372

Merged
merged 1 commit into from
Sep 17, 2019

Conversation

tstromberg
Copy link
Contributor

@tstromberg tstromberg commented Sep 16, 2019

This PR does a few things:

  • Update driver default to match the current profile
  • Move driver conflict detection to occur much earlier
  • Provide the user actionable feedback for how to workaround the conflict.
  • Use the correct driver name in the conflict message
  • Cleanup start.go by performing viper.GetString("vm-driver") only once.

Before:

./out/minikube start --vm-driver=hyperkit
😄  minikube v1.4.0-beta.2 on Darwin 10.14.6
😄  Downloading driver docker-machine-driver-hyperkit:
docker-machine-driver-hyperkit: 10.79 MiB / 10.79 MiB  100.00% 40.82 MiB p/s 1s
😄  A new hyperkit driver was installed. It needs elevated permissions to run. The following commands will be executed
...
💣  The existing "minikube" VM was created using the hyperkit driver.

After:

😄  minikube v1.4.0-beta.2 on Darwin 10.14.6
💥  You have an existing "minikube" VM that was created using the "virtualbox" driver, and is incompatible with the "hyperkit" driver.
👉  To proceed, either:
      1) Delete the existing VM using: 'minikube delete'
      or
      2) Restart with the existing driver: 'minikube start --vm-driver=virtualbox'
💣  Exiting due to driver incompatibility

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2019
@tstromberg tstromberg changed the title Use existing driver by default, improve conflict . message Use existing driver by default, improve driver conflict message Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants