Automatically install docker-machine-driver-hyperkit if missing or incompatible #5354

josedonizetti · 2019-09-14T03:43:54Z

k8s-ci-robot · 2019-09-14T03:44:31Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: josedonizetti
To complete the pull request process, please assign medyagh
You can assign the PR to them by writing /assign @medyagh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

TravisBuddy · 2019-09-14T03:51:46Z

Travis tests have failed

Hey @josedonizetti,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test

which go-bindata || GO111MODULE=off GOBIN=/home/travis/gopath/bin go get github.com/jteeuwen/go-bindata/...
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.12.9.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
which go-bindata || GO111MODULE=off GOBIN=/home/travis/gopath/bin go get github.com/jteeuwen/go-bindata/...
/home/travis/gopath/bin/go-bindata
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.12.9.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
./test.sh
= go mod ================================================================
ok
= make lint =============================================================
golangci/golangci-lint info checking GitHub for tag 'v1.17.1'
golangci/golangci-lint info found version: 1.17.1 for v1.17.1/linux/amd64
golangci/golangci-lint info installed out/linters/golangci-lint
cmd/minikube/cmd/start.go:1053:2: S1023: redundant `return` statement (gosimple)
	return
	^
Makefile:334: recipe for target 'lint-ci' failed
make[1]: *** [lint-ci] Error 1
= boilerplate ===========================================================
ok
= schema_check ==========================================================
ok
= go test ===============================================================
ok  	k8s.io/minikube/cmd/minikube/cmd	0.070s	coverage: 16.4% of statements
ok  	k8s.io/minikube/cmd/minikube/cmd/config	0.043s	coverage: 18.7% of statements
ok  	k8s.io/minikube/pkg/drivers	0.018s	coverage: 15.2% of statements
ok  	k8s.io/minikube/pkg/drivers/kvm	0.045s	coverage: 2.3% of statements
ok  	k8s.io/minikube/pkg/minikube/assets	0.078s	coverage: 61.8% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper	2.910s	coverage: 73.3% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/kubeadm	0.063s	coverage: 30.6% of statements
ok  	k8s.io/minikube/pkg/minikube/cluster	0.602s	coverage: 53.0% of statements
ok  	k8s.io/minikube/pkg/minikube/config	0.025s	coverage: 76.0% of statements
ok  	k8s.io/minikube/pkg/minikube/cruntime	0.008s	coverage: 62.4% of statements
ok  	k8s.io/minikube/pkg/minikube/extract	0.007s	coverage: 56.7% of statements
ok  	k8s.io/minikube/pkg/minikube/kubeconfig	0.084s	coverage: 75.9% of statements
ok  	k8s.io/minikube/pkg/minikube/logs	0.035s	coverage: 1.4% of statements
ok  	k8s.io/minikube/pkg/minikube/machine	0.027s	coverage: 11.3% of statements
ok  	k8s.io/minikube/pkg/minikube/notify	0.035s	coverage: 78.6% of statements
ok  	k8s.io/minikube/pkg/minikube/out	0.015s	coverage: 70.3% of statements
ok  	k8s.io/minikube/pkg/minikube/problem	0.010s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/proxy	0.011s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/registry	0.013s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/service	0.071s	coverage: 35.9% of statements
ok  	k8s.io/minikube/pkg/minikube/sshutil	0.227s	coverage: 75.0% of statements
ok  	k8s.io/minikube/pkg/minikube/translate	0.008s	coverage: 8.4% of statements
ok  	k8s.io/minikube/pkg/minikube/tunnel	2.013s	coverage: 64.5% of statements
ok  	k8s.io/minikube/pkg/util	2.069s	coverage: 62.0% of statements
ok  	k8s.io/minikube/pkg/util/lock	0.004s	coverage: 59.1% of statements
ok  	k8s.io/minikube/pkg/util/retry	0.002s	coverage: 0.0% of statements
ok
Makefile:232: recipe for target 'test' failed
make: *** [test] Error 4

TravisBuddy Request Identifier: f6465040-d6a2-11e9-82ee-13bec588d4b8

cmd/minikube/cmd/start.go

TravisBuddy · 2019-09-15T22:32:14Z

Travis tests have failed

Hey @josedonizetti,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test

which go-bindata || GO111MODULE=off GOBIN=/home/travis/gopath/bin go get github.com/jteeuwen/go-bindata/...
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.12.9.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
which go-bindata || GO111MODULE=off GOBIN=/home/travis/gopath/bin go get github.com/jteeuwen/go-bindata/...
/home/travis/gopath/bin/go-bindata
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.12.9.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
./test.sh
= go mod ================================================================
ok
= make lint =============================================================
golangci/golangci-lint info checking GitHub for tag 'v1.17.1'
golangci/golangci-lint info found version: 1.17.1 for v1.17.1/linux/amd64
golangci/golangci-lint info installed out/linters/golangci-lint
cmd/minikube/cmd/start.go:1053:2: S1023: redundant `return` statement (gosimple)
	return
	^
Makefile:334: recipe for target 'lint-ci' failed
make[1]: *** [lint-ci] Error 1
= boilerplate ===========================================================
ok
= schema_check ==========================================================
ok
= go test ===============================================================
ok  	k8s.io/minikube/cmd/minikube/cmd	0.099s	coverage: 16.4% of statements
ok  	k8s.io/minikube/cmd/minikube/cmd/config	0.076s	coverage: 18.7% of statements
ok  	k8s.io/minikube/pkg/drivers	0.018s	coverage: 15.2% of statements
ok  	k8s.io/minikube/pkg/drivers/kvm	0.057s	coverage: 2.3% of statements
ok  	k8s.io/minikube/pkg/minikube/assets	0.042s	coverage: 61.8% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper	3.304s	coverage: 73.3% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/kubeadm	0.065s	coverage: 30.6% of statements
ok  	k8s.io/minikube/pkg/minikube/cluster	0.304s	coverage: 53.0% of statements
ok  	k8s.io/minikube/pkg/minikube/config	0.027s	coverage: 76.0% of statements
ok  	k8s.io/minikube/pkg/minikube/cruntime	0.009s	coverage: 62.4% of statements
ok  	k8s.io/minikube/pkg/minikube/extract	0.020s	coverage: 56.7% of statements
ok  	k8s.io/minikube/pkg/minikube/kubeconfig	0.058s	coverage: 75.9% of statements
ok  	k8s.io/minikube/pkg/minikube/logs	0.065s	coverage: 1.4% of statements
ok  	k8s.io/minikube/pkg/minikube/machine	0.041s	coverage: 11.3% of statements
ok  	k8s.io/minikube/pkg/minikube/notify	0.031s	coverage: 78.6% of statements
ok  	k8s.io/minikube/pkg/minikube/out	0.011s	coverage: 70.3% of statements
ok  	k8s.io/minikube/pkg/minikube/problem	0.026s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/proxy	0.013s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/registry	0.024s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/service	0.047s	coverage: 35.9% of statements
ok  	k8s.io/minikube/pkg/minikube/sshutil	0.165s	coverage: 75.0% of statements
ok  	k8s.io/minikube/pkg/minikube/translate	0.016s	coverage: 8.4% of statements
ok  	k8s.io/minikube/pkg/minikube/tunnel	2.200s	coverage: 64.5% of statements
ok  	k8s.io/minikube/pkg/util	0.865s	coverage: 62.0% of statements
ok  	k8s.io/minikube/pkg/util/lock	0.008s	coverage: 59.1% of statements
ok  	k8s.io/minikube/pkg/util/retry	0.004s	coverage: 0.0% of statements
ok
Makefile:232: recipe for target 'test' failed
make: *** [test] Error 4

TravisBuddy Request Identifier: a9483350-d808-11e9-b22f-8dc32e2a8e5f

tstromberg · 2019-09-16T20:22:20Z

Looks great. Just some flakes:

none: none upgrade: kubeadm exit status 1 (bind: address already in use) #5332
hyperkit: hyperkit integration testing: could not find an IP address / OS type not recognized #5368

I would like to see this PR use an --interactive flag (#5180) to avoid breaking script writers, but am prepared to add that support in myself.

tstromberg · 2019-09-16T20:23:22Z

@minikube-bot OK to test

mjgallag · 2020-01-24T19:31:52Z

@tstromberg would it make sense to follow the same approach for hyperkit?

Add installOrUpdate hyperkit support

fb43666

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 14, 2019

k8s-ci-robot requested review from afbjorklund and tstromberg September 14, 2019 03:44

afbjorklund reviewed Sep 14, 2019

View reviewed changes

cmd/minikube/cmd/start.go Outdated Show resolved Hide resolved

cmd/minikube/cmd/start.go Outdated Show resolved Hide resolved

josedonizetti added 2 commits September 15, 2019 19:23

Fix typos

6b74e5f

Fix golint

6da3f24

tstromberg mentioned this pull request Sep 16, 2019

"docker-machine-driver-hyperkit": executable file not found in $PATH #5367

Closed

tstromberg changed the title ~~Add installOrUpdate hyperkit support~~ Automatically install docker-machine-driver-hyperkit if missing or incompatible Sep 16, 2019

tstromberg approved these changes Sep 16, 2019

View reviewed changes

tstromberg merged commit 28a1472 into kubernetes:master Sep 16, 2019

josedonizetti deleted the install-or-update-hyperkit branch September 16, 2019 22:26

diegodelemos mentioned this pull request Sep 30, 2019

installation: remove vmdriver installation step reanahub/reana-cluster#230

Closed

4 tasks

mattfarina mentioned this pull request Dec 23, 2020

Packaging for macOS rancher-sandbox/rancher-desktop#28

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Automatically install docker-machine-driver-hyperkit if missing or incompatible #5354

Automatically install docker-machine-driver-hyperkit if missing or incompatible #5354

josedonizetti commented Sep 14, 2019

k8s-ci-robot commented Sep 14, 2019

TravisBuddy commented Sep 14, 2019

TravisBuddy commented Sep 15, 2019

tstromberg commented Sep 16, 2019 •

edited

Loading

tstromberg commented Sep 16, 2019

mjgallag commented Jan 24, 2020 •

edited

Loading

Automatically install docker-machine-driver-hyperkit if missing or incompatible #5354

Automatically install docker-machine-driver-hyperkit if missing or incompatible #5354

Conversation

josedonizetti commented Sep 14, 2019

k8s-ci-robot commented Sep 14, 2019

TravisBuddy commented Sep 14, 2019

Travis tests have failed

1st Build

TravisBuddy Request Identifier: f6465040-d6a2-11e9-82ee-13bec588d4b8

TravisBuddy commented Sep 15, 2019

Travis tests have failed

1st Build

TravisBuddy Request Identifier: a9483350-d808-11e9-b22f-8dc32e2a8e5f

tstromberg commented Sep 16, 2019 • edited Loading

tstromberg commented Sep 16, 2019

mjgallag commented Jan 24, 2020 • edited Loading

tstromberg commented Sep 16, 2019 •

edited

Loading

mjgallag commented Jan 24, 2020 •

edited

Loading