Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More logs: exited containers, controller manager, double line count #5249

Merged
merged 1 commit into from
Sep 3, 2019
Merged

More logs: exited containers, controller manager, double line count #5249

merged 1 commit into from
Sep 3, 2019

Conversation

tstromberg
Copy link
Contributor

This PR is intended to make the "logs" command more useful for solving tricky issue reports:

  • Double the line count, as often many minutes occur between the failed run and "minikube logs"
  • Include logs for kube-controller-manager
  • Include logs for all containers that match, not just the first one. This includes exited containers.

Closes #5248

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 3, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2019
@tstromberg tstromberg merged commit 2635734 into kubernetes:master Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josedonizetti josedonizetti josedonizetti approved these changes

@medyagh medyagh Awaiting requested review from medyagh

@RA489 RA489 Awaiting requested review from RA489

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

logs: include logs for exited containers
3 participants
@tstromberg @k8s-ci-robot @josedonizetti