Upgrade containerd to 1.2.8.

[ianlewis]

Issue #5191

[minikube-bot]

Can one of the admins verify this patch?

[ianlewis]

/assign @tstromberg

[ianlewis]

/cc @afbjorklund

[tstromberg]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ianlewis, tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tstromberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ianlewis]

Seems the ci robot doesn't like the refs keyword either?

[k8s-ci-robot]

New changes are detected. LGTM label has been removed.

[ianlewis]

NM, looks like it didn't like the actual git commit message rather than the PR description.

[TravisBuddy]

Travis tests have failed

Hey @ianlewis,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test

which go-bindata || GO111MODULE=off GOBIN=/home/travis/gopath/bin go get github.com/jteeuwen/go-bindata/...
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.12.9.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
which go-bindata || GO111MODULE=off GOBIN=/home/travis/gopath/bin go get github.com/jteeuwen/go-bindata/...
/home/travis/gopath/bin/go-bindata
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.12.9.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
./test.sh
= go mod ================================================================
ok
= make lint =============================================================
golangci/golangci-lint info checking GitHub for tag 'v1.17.1'
golangci/golangci-lint info found version: 1.17.1 for v1.17.1/linux/amd64
golangci/golangci-lint info installed out/linters/golangci-lint
ok
= boilerplate ===========================================================
ok
= schema_check ==========================================================
ok
= go test ===============================================================
ok  	k8s.io/minikube/cmd/minikube/cmd	0.070s	coverage: 15.6% of statements
ok  	k8s.io/minikube/cmd/minikube/cmd/config	0.056s	coverage: 18.9% of statements
ok  	k8s.io/minikube/pkg/drivers	0.009s	coverage: 19.6% of statements
ok  	k8s.io/minikube/pkg/drivers/kvm	0.026s	coverage: 2.3% of statements
ok  	k8s.io/minikube/pkg/minikube/assets	0.037s	coverage: 61.8% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper	3.472s	coverage: 72.9% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/kubeadm	0.076s	coverage: 29.5% of statements
ok  	k8s.io/minikube/pkg/minikube/cluster	0.390s	coverage: 54.2% of statements
ok  	k8s.io/minikube/pkg/minikube/config	0.059s	coverage: 76.0% of statements
ok  	k8s.io/minikube/pkg/minikube/cruntime	0.030s	coverage: 62.4% of statements
ok  	k8s.io/minikube/pkg/minikube/extract	0.006s	coverage: 56.7% of statements
ok  	k8s.io/minikube/pkg/minikube/kubeconfig	0.039s	coverage: 75.6% of statements
ok  	k8s.io/minikube/pkg/minikube/logs	0.052s	coverage: 1.5% of statements
ok  	k8s.io/minikube/pkg/minikube/machine	0.032s	coverage: 12.0% of statements
ok  	k8s.io/minikube/pkg/minikube/notify	0.030s	coverage: 77.8% of statements
ok  	k8s.io/minikube/pkg/minikube/out	0.013s	coverage: 70.3% of statements
ok  	k8s.io/minikube/pkg/minikube/problem	0.005s	coverage: 42.9% of statements
ok  	k8s.io/minikube/pkg/minikube/proxy	0.008s	coverage: 67.3% of statements
ok  	k8s.io/minikube/pkg/minikube/registry	0.017s	coverage: 81.8% of statements
ok  	k8s.io/minikube/pkg/minikube/service	0.035s	coverage: 35.9% of statements
--- FAIL: TestNewSSHClient (0.85s)
    ssh_mock.go:173: Listening on 127.0.0.1:36177
    ssh_mock.go:83: Accepting...
    ssh_mock.go:83: Accepting...
    ssh_mock.go:132: exec request received: &{Type:exec WantReply:true Payload:[0 0 0 3 102 111 111] ch:0xc00010c0c0 mux:<nil>}
    sshutil_test.go:60: Error running "foo": wait: remote command exited without exit status or exit signal
    ssh_mock.go:189: Stopping
FAIL
coverage: 75.0% of statements
FAIL	k8s.io/minikube/pkg/minikube/sshutil	0.860s
ok  	k8s.io/minikube/pkg/minikube/translate	0.005s	coverage: 8.4% of statements
ok  	k8s.io/minikube/pkg/minikube/tunnel	2.021s	coverage: 64.5% of statements
ok  	k8s.io/minikube/pkg/util	1.478s	coverage: 61.6% of statements
ok  	k8s.io/minikube/pkg/util/retry	0.003s	coverage: 0.0% of statements
Makefile:229: recipe for target 'test' failed
make: *** [test] Error 16

TravisBuddy Request Identifier: 5497aad0-c7b3-11e9-854a-5595b23fa18a

[ianlewis]

/retest

[ianlewis]

I can't see how updating containerd would cause this test to fail. Is this test normally flaky?

--- FAIL: TestNewSSHClient (0.85s)
    ssh_mock.go:173: Listening on 127.0.0.1:36177
    ssh_mock.go:83: Accepting...
    ssh_mock.go:83: Accepting...
    ssh_mock.go:132: exec request received: &{Type:exec WantReply:true Payload:[0 0 0 3 102 111 111] ch:0xc00010c0c0 mux:<nil>}
    sshutil_test.go:60: Error running "foo": wait: remote command exited without exit status or exit signal
    ssh_mock.go:189: Stopping
FAIL

[ianlewis]

Tests for #4494 passed which includes this change so I'm confident it should be fine.

[tstromberg]

Know flake - merging.