Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade addons to use apps/v1 instead of extensions/v1beta1 #5028

Merged
merged 1 commit into from
Aug 26, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deploy/addons/ingress/ingress-dp.yaml.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# limitations under the License.

---
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: nginx-ingress-controller
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: metrics-server
Expand Down
7 changes: 6 additions & 1 deletion deploy/addons/registry/registry-proxy.yaml.tmpl
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: DaemonSet
metadata:
labels:
Expand All @@ -7,9 +7,14 @@ metadata:
name: registry-proxy
namespace: kube-system
spec:
selector:
matchLabels:
registry-proxy: "true"
kubernetes.io/minikube-addons: registry
template:
metadata:
labels:
registry-proxy: "true"
kubernetes.io/minikube-addons: registry
addonmanager.kubernetes.io/mode: Reconcile
spec:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ metadata:
spec:
selector:
matchLabels:
glusterfs: pod
glusterfs-node: pod
k8s-app: storage-provisioner-gluster
template:
metadata:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ data:

---
kind: Deployment
apiVersion: extensions/v1beta1
apiVersion: apps/v1
metadata:
namespace: storage-gluster
name: heketi
Expand All @@ -100,6 +100,11 @@ metadata:
description: Defines how to deploy Heketi
spec:
replicas: 1
selector:
matchLabels:
glusterfs: heketi-pod
heketi: pod
k8s-app: storage-provisioner-gluster
template:
metadata:
namespace: storage-gluster
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ subjects:
name: glusterfile-provisioner
---
kind: Deployment
apiVersion: extensions/v1beta1
apiVersion: apps/v1
metadata:
namespace: storage-gluster
name: glusterfile-provisioner
Expand All @@ -89,6 +89,10 @@ metadata:
description: Defines how to deploy the glusterfile provisioner pod.
spec:
replicas: 1
selector:
matchLabels:
glusterfs: file-provisioner-pod
glusterfile: provisioner-pod
strategy:
type: Recreate
template:
Expand Down
5 changes: 1 addition & 4 deletions test/integration/fn_addons.go
Original file line number Diff line number Diff line change
Expand Up @@ -206,10 +206,7 @@ func testRegistry(t *testing.T) {
if err := kapi.WaitForPodsWithLabelRunning(client, "kube-system", rs); err != nil {
t.Fatalf("waiting for registry pods: %v", err)
}
ps, err := labels.Parse("kubernetes.io/minikube-addons=registry,actual-registry!=true")
if err != nil {
t.Fatalf("Unable to parse selector: %v", err)
}
ps := labels.SelectorFromSet(labels.Set(map[string]string{"registry-proxy": "true"}))
if err := kapi.WaitForPodsWithLabelRunning(client, "kube-system", ps); err != nil {
t.Fatalf("waiting for registry-proxy pods: %v", err)
}
Expand Down