Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console output cleanup #4825

Merged
merged 8 commits into from
Jul 20, 2019
Merged

Conversation

sharifelgamal
Copy link
Collaborator

@sharifelgamal sharifelgamal commented Jul 19, 2019

  • Removed all non-templated output functions: OutStyle, ErrStyle, Failure, Fatal, Warning, Success, Usage, WithCode

  • Moved package console to out for brevity, renamed: console.OutT -> out.T, console.OutLn -> out.Ln, console.Out -> out.String, console.Arg -> out.V.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 19, 2019
@sharifelgamal sharifelgamal requested review from tstromberg and medyagh and removed request for RA489 July 19, 2019 20:42
cmd/minikube/cmd/ip.go Outdated Show resolved Hide resolved
cmd/minikube/cmd/config/prompt.go Outdated Show resolved Hide resolved
@sharifelgamal
Copy link
Collaborator Author

@minikube-bot OK to test

@sharifelgamal sharifelgamal merged commit 6552436 into kubernetes:master Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants