-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Console output cleanup #4825
Merged
sharifelgamal
merged 8 commits into
kubernetes:master
from
sharifelgamal:console-cleanup
Jul 20, 2019
Merged
Console output cleanup #4825
sharifelgamal
merged 8 commits into
kubernetes:master
from
sharifelgamal:console-cleanup
Jul 20, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sharifelgamal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
labels
Jul 19, 2019
sharifelgamal
requested review from
tstromberg and
medyagh
and removed request for
RA489
July 19, 2019 20:42
tstromberg
suggested changes
Jul 19, 2019
@minikube-bot OK to test |
tstromberg
approved these changes
Jul 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed all non-templated output functions: OutStyle, ErrStyle, Failure, Fatal, Warning, Success, Usage, WithCode
Moved package console to out for brevity, renamed: console.OutT -> out.T, console.OutLn -> out.Ln, console.Out -> out.String, console.Arg -> out.V.