Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make cluster_test and utils_test run in isolation #4813

Merged
merged 9 commits into from
Jul 19, 2019
Merged

Make cluster_test and utils_test run in isolation #4813

merged 9 commits into from
Jul 19, 2019

Conversation

tstromberg
Copy link
Contributor

@tstromberg tstromberg commented Jul 19, 2019 •
edited
Loading

This PR reduces "make test" latency on Travis from 9.1 minutes to 3.6 minutes, by making the following changes:

  • cluster_test: Consistently use MockDriver instead of DefaultVMDriver ("virtualbox")
  • api_mock: Use a random profile name to avoid operating against the default ("minikube")
  • utils: Remove unused ParseSHAFromURL and it's ill-conceived test that takes >30s to execute

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 19, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2019
@tstromberg tstromberg changed the title Update cluster_test to consistently use MockDriver and avoid existing profiles Isolate cluster_test from interfering with local profiles and VM's Jul 19, 2019
@tstromberg tstromberg changed the title Isolate cluster_test from interfering with local profiles and VM's Update cluster_test to consistently use mock drivers and fake profiles Jul 19, 2019
@tstromberg tstromberg changed the title Update cluster_test to consistently use mock drivers and fake profiles cluster_test: consistently use mock drivers and fake profiles Jul 19, 2019
@tstromberg tstromberg changed the title cluster_test: consistently use mock drivers and fake profiles WIP: cluster_test: consistently use mock drivers and fake profiles Jul 19, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 19, 2019
@tstromberg tstromberg changed the title WIP: cluster_test: consistently use mock drivers and fake profiles WIP: cluster_test: consistently use mock driver & fake profile Jul 19, 2019
@tstromberg tstromberg changed the title WIP: cluster_test: consistently use mock driver & fake profile Make cluster_test and utils_test run in isolation Jul 19, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 19, 2019
@tstromberg
Copy link
Contributor Author

Test failures are unrelated - due to #4820

@tstromberg tstromberg assigned tstromberg and unassigned tstromberg Jul 19, 2019
@tstromberg
Copy link
Contributor Author

@minikube-bot OK to test

@medyagh
Copy link
Member

medyagh commented Jul 19, 2019 •
edited
Loading

wow this is amazing ! it finished in 4 min 24 sec ! it used to be 9.5 mins. thank you sooo much for this.
this is gonna make contributors happier !

@tstromberg
Copy link
Contributor Author

NOTE: Next time any of ya'll are tempted to start an HTTP server for tests, please use: https://golang.org/pkg/net/http/httptest/

@tstromberg tstromberg merged commit 784717c into kubernetes:master Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharifelgamal sharifelgamal sharifelgamal approved these changes

@medyagh medyagh medyagh approved these changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tstromberg @k8s-ci-robot @medyagh @sharifelgamal