Remove ingress-nginx default backend

[reegnz]

It's not needed since nginx 0.20.0.

See the following pull-requests for context:

• do not require --default-backend-service ingress-nginx#3126
• [404-server] Removes 404 server ingress-nginx#3156

[k8s-ci-robot]

Hi @reegnz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: reegnz
To complete the pull request process, please assign medyagh
You can assign the PR to them by writing /assign @medyagh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[minikube-bot]

Can one of the admins verify this patch?

[tstromberg]

Thank you!

[tstromberg]

@minikube-bot OK to test

[medyagh]

Thanks for the contribution @reegnz the integration test for ingress fails after this change, I am curious if this is because the test needs to be updated ? or does this chance actually breaks the ingress?

  --- FAIL: TestFunctional/IngressController (671.91s)
        addons_test.go:133: waiting for default-http-backend to be up: waiting for default-http-backend deployment to stabilize: timed out waiting for the con

[reegnz]

@medyagh the default backend does not exist anymore in this PR so I'll have to remove those assertions from the tests.

[tstromberg]

@reegnz - For this failure:

    --- FAIL: TestFunctional/IngressController (665.00s)
        addons_test.go:133: waiting for default-http-backend to be up: waiting for default-http-backend deployment to stabilize: timed out waiting for the condition

You'll want to adjust this function:

minikube/test/integration/util/util.go

Line 369 in 21cd69e

if err := commonutil.WaitForDeploymentToStabilize(client, "kube-system", "default-http-backend", time.Minute*10); err != nil {

To quickly re-run this broken test locally, you can use:

env TEST_ARGS="-test.run TestFunctional/IngressController --alsologtostderr" make integration

[medyagh]

@reegnz Are you still working on this ?

[reegnz]

Yupp, gonna have a look this week.

[RA489]

@minikube-bot OK to test

[reegnz]

OK, I think I managed to find the broken test and removed the code that became unnecessary.
@tstromberg thanks for the hints, they were really helpful!

[reegnz]

/retest this please

[reegnz]

No idea what those breaking builds mean. :(

[RA489]

@minikube-bot OK to test

[reegnz]

@medyagh I rebased on master, but I have no idea why the KVM tests fail, doesn't seem to be ingress-related though. Would you give some hints please? (once the build has finished it will surely come up again).

[medyagh]

@medyagh I rebased on master, but I have no idea why the KVM tests fail, doesn't seem to be ingress-related though. Would you give some hints please? (once the build has finished it will surely come up again).

Tests are passing now ! thank you for following up on this PR ! I approve this !