Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated drivers: kvm-old and xhyve #4781

Merged
merged 12 commits into from
Jul 17, 2019
Merged

Remove deprecated drivers: kvm-old and xhyve #4781

merged 12 commits into from
Jul 17, 2019

Conversation

tstromberg
Copy link
Contributor

@tstromberg tstromberg commented Jul 16, 2019 •
edited
Loading

These drivers are no longer maintained have been deprecated for as long as I've contributed to the minikube project.

This closes #4660 #4436 #4291 #3726

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2019
@tstromberg
Copy link
Contributor Author

It looks like some of the kvm files are used by kvm2. =)

afbjorklund
afbjorklund reviewed Jul 17, 2019
View reviewed changes
docs/cli_commands.md Outdated
@@ -247,7 +247,7 @@ minikube service [command]

---
### start
**Description -** Starts a local kubernetes cluster using VM. This command assumes you have already installed one of the VM drivers: **virtualbox/parallels/vmwarefusion/kvm/xhyve/hyperv**.
**Description -** Starts a local kubernetes cluster using VM. This command assumes you have already installed one of the VM drivers: **virtualbox/parallels/vmwarefusion/kvm/hyperv**.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kvm2 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

cmd/minikube/cmd/start.go Outdated
@@ -175,7 +173,7 @@ var startCmd = &cobra.Command{
Use: "start",
Short: "Starts a local kubernetes cluster",
Long: `Starts a local kubernetes cluster using VM. This command
assumes you have already installed one of the VM drivers: virtualbox/parallels/vmwarefusion/kvm/xhyve/hyperv.`,
assumes you have already installed one of the VM drivers: virtualbox/parallels/vmwarefusion/kvm/hyperv.`,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kvm2 ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like: fmt.Sprintf("....%v", constants.SupportedVMDrivers)). Then once the PR #4738 is merged, it would list the correct drivers for each platform.

wdyt?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't find the long help here particularly useful, so I removed it.

@afbjorklund
Copy link
Collaborator

afbjorklund commented Jul 17, 2019 •
edited
Loading

The instructions seem a little confused (outdated?).

AFAIK, both the virtualbox and hyperv drivers are bundled with libmachine (compiled in), need no driver

But we still say "kvm" (as in upstream's) rather than our own kvm2, and fail to mention "hyperkit" at all ?

This only goes for the one-liner at the top of start

@afbjorklund
Copy link
Collaborator

Something to include in 1.3.0, perhaps ?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 17, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 17, 2019
@tstromberg
Copy link
Contributor Author

Thank you for the feedback. Please take another look!

afbjorklund
afbjorklund approved these changes Jul 17, 2019
View reviewed changes
Copy link
Collaborator

@afbjorklund afbjorklund left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Q: Why do we need to embed assets and translations into the driver ? Seems that we are leaking files into the lower level abstractions here, I thought the docker-machine drivers were separate entities ?

@tstromberg
Copy link
Contributor Author

Looks good!

Q: Why do we need to embed assets and translations into the driver ? Seems that we are leaking files into the lower level abstractions here, I thought the docker-machine drivers were separate entities ?

Good call. I'll revert that change and open a separate issue about the failure I noticed.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 17, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 17, 2019
@tstromberg
Copy link
Contributor Author

@minikube-bot OK to test

@tstromberg tstromberg merged commit 2623143 into kubernetes:master Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afbjorklund afbjorklund afbjorklund approved these changes

@josedonizetti josedonizetti josedonizetti approved these changes

@medyagh medyagh Awaiting requested review from medyagh

@RA489 RA489 Awaiting requested review from RA489

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Takes 95 seconds to stop a xhyve VM
4 participants
@tstromberg @k8s-ci-robot @afbjorklund @josedonizetti